cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabb...@apache.org
Subject [1/2] cordova-plugin-inappbrowser git commit: Open a new window on the browser platform
Date Tue, 05 Jan 2016 01:22:17 GMT
Repository: cordova-plugin-inappbrowser
Updated Branches:
  refs/heads/master 2fc265883 -> 9540f11fc


Open a new window on the browser platform

The URL is not supposed to change in the case of SPA.

Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/commit/3a1fea5d
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/tree/3a1fea5d
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/diff/3a1fea5d

Branch: refs/heads/master
Commit: 3a1fea5d8b1cebb852bc1b9a8b869642c9a7a318
Parents: 2fc2658
Author: robario <webmaster@robario.com>
Authored: Fri Dec 18 17:32:24 2015 +0900
Committer: robario <webmaster@robario.com>
Committed: Fri Dec 18 17:32:24 2015 +0900

----------------------------------------------------------------------
 src/browser/InAppBrowserProxy.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/blob/3a1fea5d/src/browser/InAppBrowserProxy.js
----------------------------------------------------------------------
diff --git a/src/browser/InAppBrowserProxy.js b/src/browser/InAppBrowserProxy.js
index 33fbe47..29912c7 100644
--- a/src/browser/InAppBrowserProxy.js
+++ b/src/browser/InAppBrowserProxy.js
@@ -71,8 +71,10 @@ var IAB = {
             features = args[2],
             url;
 
-        if (target === "_system" || target === "_self" || !target) {
+        if (target === "_self" || !target) {
             window.location = strUrl;
+        } else if (target === "_system") {
+            window.CDV_origSymbols['window.open'].call(window, strUrl, "_blank");
         } else {
             // "_blank" or anything else
             if (!browserWrap) {


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message