Return-Path: X-Original-To: apmail-cordova-commits-archive@www.apache.org Delivered-To: apmail-cordova-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EFB0D18A63 for ; Tue, 15 Dec 2015 17:51:50 +0000 (UTC) Received: (qmail 76443 invoked by uid 500); 15 Dec 2015 17:51:50 -0000 Delivered-To: apmail-cordova-commits-archive@cordova.apache.org Received: (qmail 76418 invoked by uid 500); 15 Dec 2015 17:51:50 -0000 Mailing-List: contact commits-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list commits@cordova.apache.org Received: (qmail 76409 invoked by uid 99); 15 Dec 2015 17:51:50 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Dec 2015 17:51:50 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 8626DE052E; Tue, 15 Dec 2015 17:51:50 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: tripod@apache.org To: commits@cordova.apache.org Message-Id: <549f597961ca47afb9afc9ebf71f1f81@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: mac commit: CB-10198 Prompt submission bug Date: Tue, 15 Dec 2015 17:51:50 +0000 (UTC) Repository: cordova-osx Updated Branches: refs/heads/master 0ba44e412 -> 599acc55e CB-10198 Prompt submission bug Fixes an issue where clicking "OK" in a pop-up prompt does not return any value (despite being entered). The previous button-value checked was the constant NSAlertDefaultReturn, but since the NSAlert was created with the 'init' constructor, the runModal method will return one of NSAlert{first,second,third}ButtonReturn constants.. This closes #27 Project: http://git-wip-us.apache.org/repos/asf/cordova-osx/repo Commit: http://git-wip-us.apache.org/repos/asf/cordova-osx/commit/599acc55 Tree: http://git-wip-us.apache.org/repos/asf/cordova-osx/tree/599acc55 Diff: http://git-wip-us.apache.org/repos/asf/cordova-osx/diff/599acc55 Branch: refs/heads/master Commit: 599acc55e7fe8008f6b1646015aea521b942ace1 Parents: 0ba44e4 Author: Andrew Authored: Mon Nov 23 20:06:19 2015 -0500 Committer: Tobias Bocanegra Committed: Tue Dec 15 09:49:32 2015 -0800 ---------------------------------------------------------------------- CordovaLib/CordovaLib/Classes/CDVWebViewDelegate.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cordova-osx/blob/599acc55/CordovaLib/CordovaLib/Classes/CDVWebViewDelegate.m ---------------------------------------------------------------------- diff --git a/CordovaLib/CordovaLib/Classes/CDVWebViewDelegate.m b/CordovaLib/CordovaLib/Classes/CDVWebViewDelegate.m index 63fced8..0859589 100644 --- a/CordovaLib/CordovaLib/Classes/CDVWebViewDelegate.m +++ b/CordovaLib/CordovaLib/Classes/CDVWebViewDelegate.m @@ -136,7 +136,7 @@ [alert setAccessoryView:input]; NSInteger button = [alert runModal]; - if (button == NSAlertDefaultReturn) { + if (button == NSAlertFirstButtonReturn) { [input validateEditing]; return [input stringValue]; } --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org For additional commands, e-mail: commits-help@cordova.apache.org