cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tri...@apache.org
Subject mac commit: CB-10198 Prompt submission bug
Date Tue, 15 Dec 2015 17:51:50 GMT
Repository: cordova-osx
Updated Branches:
  refs/heads/master 0ba44e412 -> 599acc55e


CB-10198 Prompt submission bug

Fixes an issue where clicking "OK" in a pop-up prompt does not return any value (despite being
entered). The previous button-value checked was the constant NSAlertDefaultReturn, but since
the NSAlert was created with the 'init' constructor, the runModal method will return one of
NSAlert{first,second,third}ButtonReturn constants.. This closes #27


Project: http://git-wip-us.apache.org/repos/asf/cordova-osx/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-osx/commit/599acc55
Tree: http://git-wip-us.apache.org/repos/asf/cordova-osx/tree/599acc55
Diff: http://git-wip-us.apache.org/repos/asf/cordova-osx/diff/599acc55

Branch: refs/heads/master
Commit: 599acc55e7fe8008f6b1646015aea521b942ace1
Parents: 0ba44e4
Author: Andrew <andrewkubera@gmail.com>
Authored: Mon Nov 23 20:06:19 2015 -0500
Committer: Tobias Bocanegra <tripod@adobe.com>
Committed: Tue Dec 15 09:49:32 2015 -0800

----------------------------------------------------------------------
 CordovaLib/CordovaLib/Classes/CDVWebViewDelegate.m | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-osx/blob/599acc55/CordovaLib/CordovaLib/Classes/CDVWebViewDelegate.m
----------------------------------------------------------------------
diff --git a/CordovaLib/CordovaLib/Classes/CDVWebViewDelegate.m b/CordovaLib/CordovaLib/Classes/CDVWebViewDelegate.m
index 63fced8..0859589 100644
--- a/CordovaLib/CordovaLib/Classes/CDVWebViewDelegate.m
+++ b/CordovaLib/CordovaLib/Classes/CDVWebViewDelegate.m
@@ -136,7 +136,7 @@
     [alert setAccessoryView:input];
 
     NSInteger button = [alert runModal];
-    if (button == NSAlertDefaultReturn) {
+    if (button == NSAlertFirstButtonReturn) {
         [input validateEditing];
         return [input stringValue];
     }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message