cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ste...@apache.org
Subject cordova-coho git commit: CB-9220 remove check that enforces common to be linked in lib
Date Mon, 02 Nov 2015 09:01:33 GMT
Repository: cordova-coho
Updated Branches:
  refs/heads/master 443c2f846 -> a26a7e30e


CB-9220 remove check that enforces common to be linked in lib


Project: http://git-wip-us.apache.org/repos/asf/cordova-coho/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-coho/commit/a26a7e30
Tree: http://git-wip-us.apache.org/repos/asf/cordova-coho/tree/a26a7e30
Diff: http://git-wip-us.apache.org/repos/asf/cordova-coho/diff/a26a7e30

Branch: refs/heads/master
Commit: a26a7e30e026eed5ce2b6af25064eba3690c03ef
Parents: 443c2f8
Author: Steve Gill <stevengill97@gmail.com>
Authored: Fri Oct 30 17:40:23 2015 -0700
Committer: Steve Gill <stevengill97@gmail.com>
Committed: Fri Oct 30 17:40:23 2015 -0700

----------------------------------------------------------------------
 src/create-verify-archive.js | 12 ------------
 1 file changed, 12 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-coho/blob/a26a7e30/src/create-verify-archive.js
----------------------------------------------------------------------
diff --git a/src/create-verify-archive.js b/src/create-verify-archive.js
index 577dabb..e4485ff 100644
--- a/src/create-verify-archive.js
+++ b/src/create-verify-archive.js
@@ -96,18 +96,6 @@ exports.createCommand = function*(argv) {
 
         var outPath;
         if (repo.id !=='mobile-spec') {
-            // Before doing an `npm pack` let's check if cordova-common is
-            // npm-linked to cordova-lib otherwise built package will be invalid
-            if (repo.id === 'lib') {
-                print('Verifying if "cordova-common" is npm-linked into "cordova-lib"');
-                apputil.setShellSilent(function () {
-                    shelljs.pushd(apputil.getBaseDir());
-                    if (!npm_link.verifyLink('cordova-common', 'cordova-lib')) {
-                        apputil.fatal('Module "cordova-common" is not properly npm-linked
into "cordova-lib". Run "coho npm-link" to ensure that the link set up properly.');
-                    }
-                    shelljs.popd();
-                });
-            }
 
             var pkgInfo = require(path.resolve('package'));
             var tgzname = pkgInfo.name + '-' + pkgInfo.version + '.tgz';


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message