cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ste...@apache.org
Subject cordova-coho git commit: removed stripping of prefix on plugin tags
Date Thu, 19 Nov 2015 23:44:53 GMT
Repository: cordova-coho
Updated Branches:
  refs/heads/master 652ecd15d -> 013a77e0e


removed stripping of  prefix on plugin tags


Project: http://git-wip-us.apache.org/repos/asf/cordova-coho/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-coho/commit/013a77e0
Tree: http://git-wip-us.apache.org/repos/asf/cordova-coho/tree/013a77e0
Diff: http://git-wip-us.apache.org/repos/asf/cordova-coho/diff/013a77e0

Branch: refs/heads/master
Commit: 013a77e0e442bd893d3b420c8437ddfbf50f8f9d
Parents: 652ecd1
Author: Steve Gill <stevengill97@gmail.com>
Authored: Thu Nov 19 15:44:47 2015 -0800
Committer: Steve Gill <stevengill97@gmail.com>
Committed: Thu Nov 19 15:44:47 2015 -0800

----------------------------------------------------------------------
 src/gitutil.js | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-coho/blob/013a77e0/src/gitutil.js
----------------------------------------------------------------------
diff --git a/src/gitutil.js b/src/gitutil.js
index ceea264..3c1851c 100644
--- a/src/gitutil.js
+++ b/src/gitutil.js
@@ -27,6 +27,7 @@ var semver = require('semver');
  * 'prefix-' (this allows for multiple modules in the same repo).
  * @param {string} [prefix] - An optional prefix to filter tags.
  * @returns {string} - the most recent tag, or null if no version tags are found.
+ * ignores r tags in plugins
  */
 exports.findMostRecentTag = function*(prefix) {
     prefix = prefix && prefix + "-";
@@ -34,7 +35,7 @@ exports.findMostRecentTag = function*(prefix) {
     return (yield executil.execHelper(executil.ARGS('git tag --list'), true)).split(/\s+/)
         .reduce(function (curBest, value) {
             var modifiedCurBest, modifiedValue;
-
+            //console.log('curBest: ', curBest, ' value: ', value)
             if (prefix) {
                 // Ignore values that don't start with prefix, and strip prefix from the
value we're going to test
                 if (value.indexOf(prefix) !== 0) {
@@ -45,9 +46,9 @@ exports.findMostRecentTag = function*(prefix) {
                     modifiedCurBest = curBest && curBest.substr(prefix.length);
                 }
             } else {
-                // Strip the "r" prefix that plugin repos use (ugh), but also make them look
higher than 3.0.0 tag that exists
-                modifiedCurBest = curBest.replace(/^r/, '9');
-                modifiedValue = value.replace(/^r/, '9');
+                //used to strip out r for plugins, but now leave it in so they fail semver
check
+                modifiedCurBest = curBest;
+                modifiedValue = value;
             }
 
             if (semver.valid(modifiedValue)) {


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message