cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dase...@apache.org
Subject cordova-plugin-file-transfer git commit: CB-9790 Align FileUploadOptions fileName and mimeType default parameter values to the docs on iOS
Date Thu, 15 Oct 2015 19:59:26 GMT
Repository: cordova-plugin-file-transfer
Updated Branches:
  refs/heads/master 83ee62514 -> f8b0f82df


CB-9790 Align FileUploadOptions fileName and mimeType default parameter values to the docs
on iOS

To match the documentation for FileUpload,
change fileName default value to "image.jpg"
change mimeType default value to "image/jpg"

github: close #98


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-file-transfer/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-file-transfer/commit/f8b0f82d
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-file-transfer/tree/f8b0f82d
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-file-transfer/diff/f8b0f82d

Branch: refs/heads/master
Commit: f8b0f82dfa600f2c43ce90fb44ed94d5a07c7514
Parents: 83ee625
Author: jason-ong <jasonong91@gmail.com>
Authored: Fri Aug 21 17:35:42 2015 +0800
Committer: daserge <v-seshak@microsoft.com>
Committed: Thu Oct 15 22:55:20 2015 +0300

----------------------------------------------------------------------
 src/ios/CDVFileTransfer.m | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-file-transfer/blob/f8b0f82d/src/ios/CDVFileTransfer.m
----------------------------------------------------------------------
diff --git a/src/ios/CDVFileTransfer.m b/src/ios/CDVFileTransfer.m
index 3113c26..2655e48 100644
--- a/src/ios/CDVFileTransfer.m
+++ b/src/ios/CDVFileTransfer.m
@@ -143,8 +143,8 @@ static CFIndex WriteDataToStream(NSData* data, CFWriteStreamRef stream)
     NSString* target = [command argumentAtIndex:0];
     NSString* server = [command argumentAtIndex:1];
     NSString* fileKey = [command argumentAtIndex:2 withDefault:@"file"];
-    NSString* fileName = [command argumentAtIndex:3 withDefault:@"no-filename"];
-    NSString* mimeType = [command argumentAtIndex:4 withDefault:nil];
+    NSString* fileName = [command argumentAtIndex:3 withDefault:@"image.jpg"];
+    NSString* mimeType = [command argumentAtIndex:4 withDefault:@"image/jpeg"];
     NSDictionary* options = [command argumentAtIndex:5 withDefault:nil];
     //    BOOL trustAllHosts = [[command argumentAtIndex:6 withDefault:[NSNumber numberWithBool:YES]]
boolValue]; // allow self-signed certs
     BOOL chunkedMode = [[command argumentAtIndex:7 withDefault:[NSNumber numberWithBool:YES]]
boolValue];


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message