cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bows...@apache.org
Subject [02/10] android commit: Finally got it kinda working, Geolocation is not going to work in browser anymore
Date Mon, 19 Oct 2015 17:32:07 GMT
Finally got it kinda working, Geolocation is not going to work in browser anymore


Project: http://git-wip-us.apache.org/repos/asf/cordova-android/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-android/commit/9a339437
Tree: http://git-wip-us.apache.org/repos/asf/cordova-android/tree/9a339437
Diff: http://git-wip-us.apache.org/repos/asf/cordova-android/diff/9a339437

Branch: refs/heads/master
Commit: 9a339437839f2e245e90353da5fd7b3b8b832325
Parents: 8981ddb
Author: Joe Bowser <bowserj@apache.org>
Authored: Tue Jul 14 14:58:55 2015 -0700
Committer: Joe Bowser <bowserj@apache.org>
Committed: Mon Oct 19 10:31:54 2015 -0700

----------------------------------------------------------------------
 framework/src/org/apache/cordova/CordovaPlugin.java              | 4 +++-
 .../src/org/apache/cordova/engine/SystemWebChromeClient.java     | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-android/blob/9a339437/framework/src/org/apache/cordova/CordovaPlugin.java
----------------------------------------------------------------------
diff --git a/framework/src/org/apache/cordova/CordovaPlugin.java b/framework/src/org/apache/cordova/CordovaPlugin.java
index 8ca1dd1..6cb2a3c 100644
--- a/framework/src/org/apache/cordova/CordovaPlugin.java
+++ b/framework/src/org/apache/cordova/CordovaPlugin.java
@@ -41,7 +41,7 @@ public class CordovaPlugin {
     public CordovaInterface cordova;
     protected CordovaPreferences preferences;
     private String serviceName;
-    private String [] permissions;
+    protected String [] permissions;
 
     /**
      * Call this after constructing to initialize the plugin.
@@ -387,6 +387,8 @@ public class CordovaPlugin {
                 return false;
             }
         }
+
+        return true;
     }
 
     /**

http://git-wip-us.apache.org/repos/asf/cordova-android/blob/9a339437/framework/src/org/apache/cordova/engine/SystemWebChromeClient.java
----------------------------------------------------------------------
diff --git a/framework/src/org/apache/cordova/engine/SystemWebChromeClient.java b/framework/src/org/apache/cordova/engine/SystemWebChromeClient.java
index 8c02bfa..bca847b 100755
--- a/framework/src/org/apache/cordova/engine/SystemWebChromeClient.java
+++ b/framework/src/org/apache/cordova/engine/SystemWebChromeClient.java
@@ -183,7 +183,7 @@ public class SystemWebChromeClient extends WebChromeClient {
         super.onGeolocationPermissionsShowPrompt(origin, callback);
         callback.invoke(origin, true, false);
         //Get the plugin, it should be loaded
-        CordovaPlugin geolocation = parentEngine.pluginManager.getPlugin("org.apache.cordova.geolocation.PermissionHandler");
+        CordovaPlugin geolocation = parentEngine.pluginManager.getPlugin("Geolocation");
         if(geolocation != null && !geolocation.hasPermisssion())
         {
             parentEngine.pluginManager.requestPermission(geolocation);


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message