cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robpav...@apache.org
Subject [2/4] cordova-windows git commit: CB-9515: Change to deployment propagated regression to failure cases.
Date Fri, 21 Aug 2015 18:51:33 GMT
CB-9515: Change to deployment propagated regression to failure cases.


Project: http://git-wip-us.apache.org/repos/asf/cordova-windows/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-windows/commit/1f4e04f5
Tree: http://git-wip-us.apache.org/repos/asf/cordova-windows/tree/1f4e04f5
Diff: http://git-wip-us.apache.org/repos/asf/cordova-windows/diff/1f4e04f5

Branch: refs/heads/master
Commit: 1f4e04f5e4fe1356e20bc9a9ecadf2b7cc054b3d
Parents: 1d3c3b1
Author: Rob Paveza <Rob.Paveza@microsoft.com>
Authored: Fri Aug 21 09:15:02 2015 -0700
Committer: Rob Paveza <Rob.Paveza@microsoft.com>
Committed: Fri Aug 21 09:23:29 2015 -0700

----------------------------------------------------------------------
 template/cordova/lib/package.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-windows/blob/1f4e04f5/template/cordova/lib/package.js
----------------------------------------------------------------------
diff --git a/template/cordova/lib/package.js b/template/cordova/lib/package.js
index 56c7c2f..9664987 100644
--- a/template/cordova/lib/package.js
+++ b/template/cordova/lib/package.js
@@ -192,13 +192,13 @@ module.exports.deployToPhone = function (package, deployTarget, targetWindows10,
                     console.log('Deploying app package...');
                     return deploymentTool.installAppPackage(package.appx, target, /*shouldLaunch*/
true, /*shouldUpdate*/ false);
                 }).then(function() { }, function(error) {
-                    if (error.indexOf('Error code 2148734208 for command') === 0) {
+                    if (error.message.indexOf('Error code 2148734208 for command') === 0)
{
                         return deploymentTool.installAppPackage(package.appx, target, /*shouldLaunch*/
true, /*shouldUpdate*/ true);
-                    } else if (error.indexOf('Error code -2146233088') === 0) {
+                    } else if (error.message.indexOf('Error code -2146233088') === 0) {
                         throw new Error('No Windows Phone device was detected.');
                     } else {
                         console.warn('Unexpected error from installation:');
-                        console.warn(error);
+                        console.warn(error.message);
                         console.warn('You may have previously installed the app with an earlier
version of cordova-windows.');
                         console.warn('Ensure the app is uninstalled from the phone and then
try to run again.');
                         throw error;


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message