cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabb...@apache.org
Subject [3/4] cordova-plugin-file-transfer git commit: Updated code per code review.
Date Thu, 18 Jun 2015 03:11:56 GMT
Updated code per code review.


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-file-transfer/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-file-transfer/commit/f17b7fcd
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-file-transfer/tree/f17b7fcd
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-file-transfer/diff/f17b7fcd

Branch: refs/heads/master
Commit: f17b7fcdd109eaf5e51db68cc7b316380e93ceef
Parents: f52d324
Author: aroberson <adam.roberson@ventyx.abb.com>
Authored: Mon Jun 15 20:38:21 2015 -0500
Committer: aroberson <adam.roberson@ventyx.abb.com>
Committed: Mon Jun 15 20:38:21 2015 -0500

----------------------------------------------------------------------
 www/browser/FileTransfer.js | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-file-transfer/blob/f17b7fcd/www/browser/FileTransfer.js
----------------------------------------------------------------------
diff --git a/www/browser/FileTransfer.js b/www/browser/FileTransfer.js
index 98816ee..2146ed1 100644
--- a/www/browser/FileTransfer.js
+++ b/www/browser/FileTransfer.js
@@ -122,9 +122,7 @@ FileTransfer.prototype.upload = function(filePath, server, successCallback,
erro
 
     var that = this;
     var xhr = transfers[this._id] = new XMLHttpRequest();
-    if (withCredentials) {
-        xhr.withCredentials = true;
-    }
+    xhr.withCredentials = withCredentials;
 
     var fail = errorCallback && function(code, status, response) {
         transfers[this._id] && delete transfers[this._id];
@@ -236,9 +234,7 @@ FileTransfer.prototype.download = function(source, target, successCallback,
erro
 
     var that = this;
     var xhr = transfers[this._id] = new XMLHttpRequest();
-    if (withCredentials) {
-        xhr.withCredentials = true;
-    }
+    xhr.withCredentials = withCredentials;
     var fail = errorCallback && function(code, status, response) {
         transfers[that._id] && delete transfers[that._id];
         // In XHR GET reqests we're setting response type to Blob


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message