cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shaz...@apache.org
Subject cordova-plugin-camera git commit: CB-8601 - iOS camera unit tests broken
Date Tue, 12 May 2015 00:39:08 GMT
Repository: cordova-plugin-camera
Updated Branches:
  refs/heads/master 9f9e5ef4a -> 706a3aa73


CB-8601 - iOS camera unit tests broken


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-camera/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-camera/commit/706a3aa7
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-camera/tree/706a3aa7
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-camera/diff/706a3aa7

Branch: refs/heads/master
Commit: 706a3aa73ed20e748fad3d95006ede002c08ed4a
Parents: 9f9e5ef
Author: Shazron Abdullah <shazron@apache.org>
Authored: Mon May 11 17:39:40 2015 -0700
Committer: Shazron Abdullah <shazron@apache.org>
Committed: Mon May 11 17:39:40 2015 -0700

----------------------------------------------------------------------
 .../CDVCameraLibTests/CameraTest.m              | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-camera/blob/706a3aa7/tests/ios/CDVCameraTest/CDVCameraLibTests/CameraTest.m
----------------------------------------------------------------------
diff --git a/tests/ios/CDVCameraTest/CDVCameraLibTests/CameraTest.m b/tests/ios/CDVCameraTest/CDVCameraLibTests/CameraTest.m
index d0e8b4b..4211198 100644
--- a/tests/ios/CDVCameraTest/CDVCameraLibTests/CameraTest.m
+++ b/tests/ios/CDVCameraTest/CDVCameraLibTests/CameraTest.m
@@ -65,7 +65,9 @@
     
     // No arguments, check whether the defaults are set
     args = @[];
-    options = [CDVPictureOptions createFromTakePictureArguments:args];
+    CDVInvokedUrlCommand* command = [[CDVInvokedUrlCommand alloc] initWithArguments:args
callbackId:@"dummy" className:@"myclassname" methodName:@"mymethodname"];
+    
+    options = [CDVPictureOptions createFromTakePictureArguments:command];
     
     XCTAssertEqual([options.quality intValue], 50);
     XCTAssertEqual(options.destinationType, (int)DestinationTypeFileUri);
@@ -99,7 +101,9 @@
              popoverOptions,
              @(UIImagePickerControllerCameraDeviceFront),
              ];
-    options = [CDVPictureOptions createFromTakePictureArguments:args];
+    
+    command = [[CDVInvokedUrlCommand alloc] initWithArguments:args callbackId:@"dummy" className:@"myclassname"
methodName:@"mymethodname"];
+    options = [CDVPictureOptions createFromTakePictureArguments:command];
     
     XCTAssertEqual([options.quality intValue], 49);
     XCTAssertEqual(options.destinationType, (int)DestinationTypeDataUrl);
@@ -141,7 +145,9 @@
              popoverOptions,
              @(UIImagePickerControllerCameraDeviceFront),
              ];
-    pictureOptions = [CDVPictureOptions createFromTakePictureArguments:args];
+    
+    CDVInvokedUrlCommand* command = [[CDVInvokedUrlCommand alloc] initWithArguments:args
callbackId:@"dummy" className:@"myclassname" methodName:@"mymethodname"];
+    pictureOptions = [CDVPictureOptions createFromTakePictureArguments:command];
     
     if ([UIImagePickerController isSourceTypeAvailable:pictureOptions.sourceType]) {
         picker = [CDVCameraPicker createFromPictureOptions:pictureOptions];
@@ -170,7 +176,9 @@
           popoverOptions,
           @(UIImagePickerControllerCameraDeviceFront),
           ];
-    pictureOptions = [CDVPictureOptions createFromTakePictureArguments:args];
+    
+    command = [[CDVInvokedUrlCommand alloc] initWithArguments:args callbackId:@"dummy" className:@"myclassname"
methodName:@"mymethodname"];
+    pictureOptions = [CDVPictureOptions createFromTakePictureArguments:command];
 
     if ([UIImagePickerController isSourceTypeAvailable:pictureOptions.sourceType]) {
         picker = [CDVCameraPicker createFromPictureOptions:pictureOptions];
@@ -198,7 +206,9 @@
              popoverOptions,
              @(UIImagePickerControllerCameraDeviceFront),
              ];
-    pictureOptions = [CDVPictureOptions createFromTakePictureArguments:args];
+    
+    command = [[CDVInvokedUrlCommand alloc] initWithArguments:args callbackId:@"dummy" className:@"myclassname"
methodName:@"mymethodname"];
+    pictureOptions = [CDVPictureOptions createFromTakePictureArguments:command];
     
     if ([UIImagePickerController isSourceTypeAvailable:pictureOptions.sourceType]) {
         picker = [CDVCameraPicker createFromPictureOptions:pictureOptions];


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message