cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shaz...@apache.org
Subject cordova-lib git commit: CB-8783 - Revert 'all' as a global preference value for Orientation (specific to iOS for now)
Date Wed, 27 May 2015 23:19:25 GMT
Repository: cordova-lib
Updated Branches:
  refs/heads/master 518ffa46c -> a05f448b4


CB-8783 - Revert 'all' as a global preference value for Orientation (specific to iOS for now)


Project: http://git-wip-us.apache.org/repos/asf/cordova-lib/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-lib/commit/a05f448b
Tree: http://git-wip-us.apache.org/repos/asf/cordova-lib/tree/a05f448b
Diff: http://git-wip-us.apache.org/repos/asf/cordova-lib/diff/a05f448b

Branch: refs/heads/master
Commit: a05f448b48dd7634696fcf2ece91e0b978348be9
Parents: 518ffa4
Author: Shazron Abdullah <shazron@apache.org>
Authored: Wed May 27 16:19:24 2015 -0700
Committer: Shazron Abdullah <shazron@apache.org>
Committed: Wed May 27 16:19:24 2015 -0700

----------------------------------------------------------------------
 .../spec-cordova/metadata/parserhelper/preferences.spec.js       | 3 +--
 cordova-lib/src/cordova/metadata/parserhelper/preferences.js     | 4 +---
 2 files changed, 2 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-lib/blob/a05f448b/cordova-lib/spec-cordova/metadata/parserhelper/preferences.spec.js
----------------------------------------------------------------------
diff --git a/cordova-lib/spec-cordova/metadata/parserhelper/preferences.spec.js b/cordova-lib/spec-cordova/metadata/parserhelper/preferences.spec.js
index 88368df..e44b0ac 100644
--- a/cordova-lib/spec-cordova/metadata/parserhelper/preferences.spec.js
+++ b/cordova-lib/spec-cordova/metadata/parserhelper/preferences.spec.js
@@ -35,8 +35,7 @@ describe('preferences', function() {
             expect(preferences.ORIENTATION_DEFAULT).toEqual('default');
             expect(preferences.ORIENTATION_PORTRAIT).toEqual('portrait');
             expect(preferences.ORIENTATION_LANDSCAPE).toEqual('landscape');
-            expect(preferences.ORIENTATION_ALL).toEqual('all');
-            expect(preferences.ORIENTATION_GLOBAL_ORIENTATIONS).toEqual([ 'default', 'portrait',
'landscape', 'all' ]);
+            expect(preferences.ORIENTATION_GLOBAL_ORIENTATIONS).toEqual([ 'default', 'portrait',
'landscape' ]);
         });
 
     });

http://git-wip-us.apache.org/repos/asf/cordova-lib/blob/a05f448b/cordova-lib/src/cordova/metadata/parserhelper/preferences.js
----------------------------------------------------------------------
diff --git a/cordova-lib/src/cordova/metadata/parserhelper/preferences.js b/cordova-lib/src/cordova/metadata/parserhelper/preferences.js
index f645f9d..1906bc6 100644
--- a/cordova-lib/src/cordova/metadata/parserhelper/preferences.js
+++ b/cordova-lib/src/cordova/metadata/parserhelper/preferences.js
@@ -26,15 +26,13 @@ var events = require('../../../events');
 var _ORIENTATION_DEFAULT = 'default';
 var _ORIENTATION_PORTRAIT = 'portrait';
 var _ORIENTATION_LANDSCAPE = 'landscape';
-var _ORIENTATION_ALL = 'all';
-var _ORIENTATION_GLOBAL_ORIENTATIONS = [ _ORIENTATION_DEFAULT, _ORIENTATION_PORTRAIT, _ORIENTATION_LANDSCAPE,
_ORIENTATION_ALL ];
+var _ORIENTATION_GLOBAL_ORIENTATIONS = [ _ORIENTATION_DEFAULT, _ORIENTATION_PORTRAIT, _ORIENTATION_LANDSCAPE
];
 
 module.exports = {
 
     ORIENTATION_DEFAULT: _ORIENTATION_DEFAULT,
     ORIENTATION_PORTRAIT: _ORIENTATION_PORTRAIT,
     ORIENTATION_LANDSCAPE: _ORIENTATION_LANDSCAPE,
-    ORIENTATION_ALL: _ORIENTATION_ALL,
     ORIENTATION_GLOBAL_ORIENTATIONS: _ORIENTATION_GLOBAL_ORIENTATIONS,
 
     /**


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message