cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bows...@apache.org
Subject cordova-plugin-splashscreen git commit: CB-8904: Don't reset the static variable when it's destroyed, otherwise we might as well just have a member variable
Date Thu, 07 May 2015 22:59:43 GMT
Repository: cordova-plugin-splashscreen
Updated Branches:
  refs/heads/master b7750760f -> 6cc3d1f3f


CB-8904: Don't reset the static variable when it's destroyed, otherwise we might as well just
have a member variable


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/commit/6cc3d1f3
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/tree/6cc3d1f3
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/diff/6cc3d1f3

Branch: refs/heads/master
Commit: 6cc3d1f3fe71309055a9f3778c75c5360c0a1ec6
Parents: b775076
Author: Joe Bowser <bowserj@apache.org>
Authored: Thu May 7 15:59:22 2015 -0700
Committer: Joe Bowser <bowserj@apache.org>
Committed: Thu May 7 15:59:39 2015 -0700

----------------------------------------------------------------------
 src/android/SplashScreen.java | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/blob/6cc3d1f3/src/android/SplashScreen.java
----------------------------------------------------------------------
diff --git a/src/android/SplashScreen.java b/src/android/SplashScreen.java
index 9258a27..75ad724 100644
--- a/src/android/SplashScreen.java
+++ b/src/android/SplashScreen.java
@@ -117,7 +117,8 @@ public class SplashScreen extends CordovaPlugin {
         }
         // hide the splash screen to avoid leaking a window
         this.removeSplashScreen();
-        firstShow = true;
+        // If we set this to true onDestroy, we lose track when we go from page to page!
+        //firstShow = true;
     }
 
     @Override


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message