cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From an-s...@apache.org
Subject cordova-lib git commit: CB-7698 BugFix: For plugins which require variables, 'cordova plugin add FOO' should fail when no variables specified.
Date Fri, 13 Mar 2015 15:06:31 GMT
Repository: cordova-lib
Updated Branches:
  refs/heads/master 24e9d8a49 -> b03b4d7dd


CB-7698 BugFix: For plugins which require variables, 'cordova plugin add FOO' should fail
when no variables specified.


Project: http://git-wip-us.apache.org/repos/asf/cordova-lib/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-lib/commit/b03b4d7d
Tree: http://git-wip-us.apache.org/repos/asf/cordova-lib/tree/b03b4d7d
Diff: http://git-wip-us.apache.org/repos/asf/cordova-lib/diff/b03b4d7d

Branch: refs/heads/master
Commit: b03b4d7ddec982b00e6f009468ffa8db59c56e1c
Parents: 24e9d8a
Author: Omar Mefire <ommenjik@microsoft.com>
Authored: Tue Mar 10 23:46:07 2015 -0700
Committer: Vladimir Kotikov <v-vlkoti@microsoft.com>
Committed: Fri Mar 13 18:05:58 2015 +0300

----------------------------------------------------------------------
 cordova-lib/src/cordova/plugin.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-lib/blob/b03b4d7d/cordova-lib/src/cordova/plugin.js
----------------------------------------------------------------------
diff --git a/cordova-lib/src/cordova/plugin.js b/cordova-lib/src/cordova/plugin.js
index 46b1928..4adfa9a 100644
--- a/cordova-lib/src/cordova/plugin.js
+++ b/cordova-lib/src/cordova/plugin.js
@@ -187,8 +187,8 @@ module.exports = function plugin(command, targets, opts) {
                             });
                         if (missingVariables.length) {
                             shell.rm('-rf', dir);
-                            events.emit('results', 'Variable(s) missing (use: --variable
' + missingVariables.join('=value --variable ') + '=value).');
-                            return;
+                            var msg = 'Variable(s) missing (use: --variable ' + missingVariables.join('=value
--variable ') + '=value).';
+                            return Q.reject(new CordovaError(msg));
                         }
                         // Iterate (in serial!) over all platforms in the project and install
the plugin.
                         return platformList.reduce(function(soFar, platform) {


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message