cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ste...@apache.org
Subject [04/11] cordova-lib git commit: CB-8577 - Read plugin variables from correct tag
Date Tue, 03 Mar 2015 08:31:01 GMT
CB-8577 - Read plugin variables from correct tag

Reads the plugin variables from param, instead of the erroneous variable tag

github: close #174


Project: http://git-wip-us.apache.org/repos/asf/cordova-lib/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-lib/commit/4c0fec7d
Tree: http://git-wip-us.apache.org/repos/asf/cordova-lib/tree/4c0fec7d
Diff: http://git-wip-us.apache.org/repos/asf/cordova-lib/diff/4c0fec7d

Branch: refs/heads/CB-8551
Commit: 4c0fec7d30df238cfc4c834a4235b2c8fcf330ad
Parents: 0c74228
Author: Gorkem Ercan <gorkem.ercan@gmail.com>
Authored: Sun Mar 1 19:28:31 2015 -0500
Committer: Gorkem Ercan <gorkem.ercan@gmail.com>
Committed: Sun Mar 1 20:09:47 2015 -0500

----------------------------------------------------------------------
 cordova-lib/spec-cordova/test-config.xml     | 2 +-
 cordova-lib/src/configparser/ConfigParser.js | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-lib/blob/4c0fec7d/cordova-lib/spec-cordova/test-config.xml
----------------------------------------------------------------------
diff --git a/cordova-lib/spec-cordova/test-config.xml b/cordova-lib/spec-cordova/test-config.xml
index 9f2490d..21d91ab 100644
--- a/cordova-lib/spec-cordova/test-config.xml
+++ b/cordova-lib/spec-cordova/test-config.xml
@@ -32,7 +32,7 @@
     <!-- Features -->
     <feature name="A feature with preference">
         <param name="id" value="org.apache.cordova.featurewithvars"/>
-        <variable name="var" value="varvalue"/>
+        <param name="var" value="varvalue"/>
     </feature>
     <feature name="A feature with url">
         <param name="id" value="org.apache.cordova.featurewithurl" />

http://git-wip-us.apache.org/repos/asf/cordova-lib/blob/4c0fec7d/cordova-lib/src/configparser/ConfigParser.js
----------------------------------------------------------------------
diff --git a/cordova-lib/src/configparser/ConfigParser.js b/cordova-lib/src/configparser/ConfigParser.js
index 05292a6..fafc76f 100644
--- a/cordova-lib/src/configparser/ConfigParser.js
+++ b/cordova-lib/src/configparser/ConfigParser.js
@@ -334,7 +334,7 @@ ConfigParser.prototype = {
         );
 
         // Iterate preferences
-        result.variables = processChildren('variable');
+        result.variables = processChildren('param');
 
         return result;
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message