cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabb...@apache.org
Subject [08/13] cordova-plugin-file-transfer git commit: CB-8407 Removes excess path to native path conversion in download method
Date Thu, 12 Feb 2015 01:49:04 GMT
CB-8407 Removes excess path to native path conversion in download method

This fixes file transfer download tests failures, when target file is specified by ms-appdata:///
uri on Windows.


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-file-transfer/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-file-transfer/commit/28189e54
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-file-transfer/tree/28189e54
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-file-transfer/diff/28189e54

Branch: refs/heads/master
Commit: 28189e54f38bc61d4f28b117dfee6d9521f3bf3c
Parents: 976275e
Author: Vladimir Kotikov <v-vlkoti@microsoft.com>
Authored: Tue Feb 3 15:50:31 2015 +0300
Committer: Jesse MacFadyen <purplecabbage@gmail.com>
Committed: Wed Feb 11 17:46:03 2015 -0800

----------------------------------------------------------------------
 src/windows/FileTransferProxy.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-file-transfer/blob/28189e54/src/windows/FileTransferProxy.js
----------------------------------------------------------------------
diff --git a/src/windows/FileTransferProxy.js b/src/windows/FileTransferProxy.js
index 453b02b..2649282 100644
--- a/src/windows/FileTransferProxy.js
+++ b/src/windows/FileTransferProxy.js
@@ -237,7 +237,7 @@ exec(win, fail, 'FileTransfer', 'upload',
     // [source, target, trustAllHosts, id, headers]
     download:function(successCallback, errorCallback, options) {
         var source = options[0];
-        var target = cordovaPathToNative(options[1]);
+        var target = options[1];
         var downloadId = options[3];
         var headers = options[4] || {};
 
@@ -252,7 +252,7 @@ exec(win, fail, 'FileTransfer', 'upload',
             target = target.replace('ms-appdata:///local', appData.localFolder.path)
                            .replace('ms-appdata:///temp', appData.temporaryFolder.path);
         }
-        target = cordovaPathToNative(target); // again?
+        target = cordovaPathToNative(target);
 
         var path = target.substr(0, target.lastIndexOf("\\"));
         var fileName = target.substr(target.lastIndexOf("\\") + 1);


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message