cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agri...@apache.org
Subject cordova-coho git commit: Update code-reviews.md to no longer mention reviewboard
Date Fri, 09 Jan 2015 02:38:24 GMT
Repository: cordova-coho
Updated Branches:
  refs/heads/master 7a568a09e -> 03779576d


Update code-reviews.md to no longer mention reviewboard


Project: http://git-wip-us.apache.org/repos/asf/cordova-coho/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-coho/commit/03779576
Tree: http://git-wip-us.apache.org/repos/asf/cordova-coho/tree/03779576
Diff: http://git-wip-us.apache.org/repos/asf/cordova-coho/diff/03779576

Branch: refs/heads/master
Commit: 03779576da154c1ec4c0df18d07476ab0cfd331d
Parents: 7a568a0
Author: Andrew Grieve <agrieve@chromium.org>
Authored: Thu Jan 8 21:37:57 2015 -0500
Committer: Andrew Grieve <agrieve@chromium.org>
Committed: Thu Jan 8 21:37:57 2015 -0500

----------------------------------------------------------------------
 docs/code-reviews.md | 23 ++++-------------------
 1 file changed, 4 insertions(+), 19 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-coho/blob/03779576/docs/code-reviews.md
----------------------------------------------------------------------
diff --git a/docs/code-reviews.md b/docs/code-reviews.md
index 3136f70..8b4e303 100644
--- a/docs/code-reviews.md
+++ b/docs/code-reviews.md
@@ -21,23 +21,8 @@
 
 # Code Reviews
 
-TODO: Review Board didn't really work out :(. Come up with something better.
+We use GitHub pull requests for code reviews.
+1. Commit to a branch on your own fork of the repo that you're changing
+2. Use GitHub to create a pull request
+3. Email out the link to it
 
- * Use http://reviews.apache.org/ to create a review request.
-   * You will need a Review Board userid and password. One can be requested from the site.
-   * By default, the ML will be notified of your review request.
-   * If you have someone in particular that you would like approval from, be sure to add
them in "People" field of the review.
-   * To create your review request is to use [post-review](http://www.reviewboard.org/docs/rbtools/dev/)
(RBTools) from the repo with the change, only if the repo contains the file '.reviewboardrc'
-     Currently the following repos contain .reviewboardrc:
-     cordova-coho
-     cordova-cli
-     cordova-android
-     cordova-ios
-     cordova-js
-
-   * If you don't want to use post-review tool, then on the web site:
-     * Click "New Review Request"
-     * On your workstation do a git diff and pipe the output to a file. In the new request,
select the git repo, the base dir where you did the diff, upload the diff file you created,
and click Create.
-     * On the next web page, fill in the description text, the name of the Branch (i.e.,
"master"), the Bug (i.e., "CB-4960"), the Description and the Testing Done fields. If you
want a review from a specific person, enter their userid / name in the People field. If you
want input from the whole community, enter "cordova" in the Groups field. Click the Submit
button.
-   * After you have received sufficient feedback, click the button to mark your review as
Discarded or Submitted [to a stream].
-   * If you don't want to use ReviewBoard you can use Github Pull Request


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message