cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agri...@apache.org
Subject js commit: CB-8210 Remove unused onDestroy channel (close #99)
Date Mon, 12 Jan 2015 15:46:45 GMT
Repository: cordova-js
Updated Branches:
  refs/heads/master ee7b91f28 -> 24ab68554


CB-8210 Remove unused onDestroy channel (close #99)

- Channel was defined as internal event and fired by javascript eval()
- Rather than change firing of event, simpler to remove as was not used


Project: http://git-wip-us.apache.org/repos/asf/cordova-js/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-js/commit/24ab6855
Tree: http://git-wip-us.apache.org/repos/asf/cordova-js/tree/24ab6855
Diff: http://git-wip-us.apache.org/repos/asf/cordova-js/diff/24ab6855

Branch: refs/heads/master
Commit: 24ab6855470f2dc0662624b597c98585e56a1666
Parents: ee7b91f
Author: Jason Chase <jasonpchase@gmail.com>
Authored: Fri Jan 9 13:53:46 2015 -0500
Committer: Andrew Grieve <agrieve@chromium.org>
Committed: Mon Jan 12 10:46:30 2015 -0500

----------------------------------------------------------------------
 src/common/channel.js | 4 ----
 1 file changed, 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-js/blob/24ab6855/src/common/channel.js
----------------------------------------------------------------------
diff --git a/src/common/channel.js b/src/common/channel.js
index f3d83df..06e2b8f 100644
--- a/src/common/channel.js
+++ b/src/common/channel.js
@@ -35,7 +35,6 @@ var utils = require('cordova/utils'),
  * onDeviceReady*              User event fired to indicate that Cordova is ready
  * onResume                    User event fired to indicate a start/resume lifecycle event
  * onPause                     User event fired to indicate a pause lifecycle event
- * onDestroy*                  Internal event fired when app is being destroyed (User should
use window.onunload event, not this one).
  *
  * The events marked with an * are sticky. Once they have fired, they will stay in the fired
state.
  * All listeners that subscribe after the event is fired will be executed right away.
@@ -247,9 +246,6 @@ channel.create('onResume');
 // Event to indicate a pause lifecycle event
 channel.create('onPause');
 
-// Event to indicate a destroy lifecycle event
-channel.createSticky('onDestroy');
-
 // Channels that must fire before "deviceready" is fired.
 channel.waitForInitialization('onCordovaReady');
 channel.waitForInitialization('onDOMContentLoaded');


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message