cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabb...@apache.org
Subject js commit: decided to JUST comment, and remove the empty code block I added.
Date Thu, 08 Jan 2015 23:35:47 GMT
Repository: cordova-js
Updated Branches:
  refs/heads/master 9966b3a69 -> f2f290627


decided to JUST comment, and remove the empty code block I added.


Project: http://git-wip-us.apache.org/repos/asf/cordova-js/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-js/commit/f2f29062
Tree: http://git-wip-us.apache.org/repos/asf/cordova-js/tree/f2f29062
Diff: http://git-wip-us.apache.org/repos/asf/cordova-js/diff/f2f29062

Branch: refs/heads/master
Commit: f2f290627002fdb6711b1c6b7df968ea03a4e850
Parents: 9966b3a
Author: Jesse MacFadyen <purplecabbage@gmail.com>
Authored: Thu Jan 8 15:35:31 2015 -0800
Committer: Jesse MacFadyen <purplecabbage@gmail.com>
Committed: Thu Jan 8 15:35:31 2015 -0800

----------------------------------------------------------------------
 src/cordova.js   | 14 +++++++-------
 src/cordova_b.js | 13 +++++++------
 2 files changed, 14 insertions(+), 13 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-js/blob/f2f29062/src/cordova.js
----------------------------------------------------------------------
diff --git a/src/cordova.js b/src/cordova.js
index 4acf29c..da3fdbe 100644
--- a/src/cordova.js
+++ b/src/cordova.js
@@ -205,13 +205,13 @@ var cordova = {
                 } else if (!isSuccess) {
                     callback.fail && callback.fail.apply(null, args);
                 }
-                else {
-                    // Note, this case is intentionally not caught.
-                    // this can happen if isSuccess is true, but callbackStatus is NO_RESULT
-                    // which is used to remove a callback from the list without calling the
callbacks
-                    // typically keepCallback is false in this case
-                }
-
+                /*
+                else
+                    Note, this case is intentionally not caught.
+                    this can happen if isSuccess is true, but callbackStatus is NO_RESULT
+                    which is used to remove a callback from the list without calling the
callbacks
+                    typically keepCallback is false in this case
+                */
                 // Clear callback if not expecting any more results
                 if (!keepCallback) {
                     delete cordova.callbacks[callbackId];

http://git-wip-us.apache.org/repos/asf/cordova-js/blob/f2f29062/src/cordova_b.js
----------------------------------------------------------------------
diff --git a/src/cordova_b.js b/src/cordova_b.js
index ea63d9d..0b85f4a 100644
--- a/src/cordova_b.js
+++ b/src/cordova_b.js
@@ -212,12 +212,13 @@ var cordova = {
                 } else if (!isSuccess) {
                     callback.fail && callback.fail.apply(null, args);
                 }
-                else {
-                    // Note, this case is intentionally not caught.
-                    // this can happen if isSuccess is true, but callbackStatus is NO_RESULT
-                    // which is used to remove a callback from the list without calling the
callbacks
-                    // typically keepCallback is false in this case
-                }
+                /*
+                else
+                    Note, this case is intentionally not caught.
+                    this can happen if isSuccess is true, but callbackStatus is NO_RESULT
+                    which is used to remove a callback from the list without calling the
callbacks
+                    typically keepCallback is false in this case
+                */
 
                 // Clear callback if not expecting any more results
                 if (!keepCallback) {


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message