cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agri...@apache.org
Subject [10/13] cordova-app-harness git commit: Fix "Unable to bind to port" message when wifi is disabled.
Date Wed, 31 Dec 2014 05:57:00 GMT
Fix "Unable to bind to port" message when wifi is disabled.

Instead, display that you are bound to localhost, which is perfectly
fine for deploying via USB.


Project: http://git-wip-us.apache.org/repos/asf/cordova-app-harness/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-app-harness/commit/1d3f2789
Tree: http://git-wip-us.apache.org/repos/asf/cordova-app-harness/tree/1d3f2789
Diff: http://git-wip-us.apache.org/repos/asf/cordova-app-harness/diff/1d3f2789

Branch: refs/heads/master
Commit: 1d3f2789268eb786227be9790b8b1137c9518493
Parents: d3e0898
Author: Andrew Grieve <agrieve@chromium.org>
Authored: Fri Nov 14 21:50:41 2014 +0100
Committer: Andrew Grieve <agrieve@chromium.org>
Committed: Wed Dec 31 00:50:14 2014 -0500

----------------------------------------------------------------------
 www/cdvah/js/ListCtrl.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-app-harness/blob/1d3f2789/www/cdvah/js/ListCtrl.js
----------------------------------------------------------------------
diff --git a/www/cdvah/js/ListCtrl.js b/www/cdvah/js/ListCtrl.js
index b831a69..84740b1 100644
--- a/www/cdvah/js/ListCtrl.js
+++ b/www/cdvah/js/ListCtrl.js
@@ -34,7 +34,8 @@
                 var getInfoCallback = function() {
                     HarnessServer.getListenAddress(/* skipCache */ true)
                     .then(function(value) {
-                        $scope.ipAddress = value ? value : 'Failed to start server';
+                        // No IP addresses happens when wifi is not connected.
+                        $scope.ipAddress = value ? value : '127.0.0.1';
                     });
                 };
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message