cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agri...@apache.org
Subject [3/4] android commit: CB-8147 Have corodva/build warn about unrecognized flags rather than fail
Date Thu, 11 Dec 2014 02:03:21 GMT
CB-8147 Have corodva/build warn about unrecognized flags rather than fail

Close #127


Project: http://git-wip-us.apache.org/repos/asf/cordova-android/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-android/commit/3aca14d5
Tree: http://git-wip-us.apache.org/repos/asf/cordova-android/tree/3aca14d5
Diff: http://git-wip-us.apache.org/repos/asf/cordova-android/diff/3aca14d5

Branch: refs/heads/master
Commit: 3aca14d5306811985354486a434d7819ea2357cc
Parents: aa2d396
Author: Andrew Grieve <agrieve@chromium.org>
Authored: Wed Dec 10 20:30:59 2014 -0500
Committer: Andrew Grieve <agrieve@chromium.org>
Committed: Wed Dec 10 21:02:57 2014 -0500

----------------------------------------------------------------------
 bin/templates/cordova/lib/build.js | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-android/blob/3aca14d5/bin/templates/cordova/lib/build.js
----------------------------------------------------------------------
diff --git a/bin/templates/cordova/lib/build.js b/bin/templates/cordova/lib/build.js
index 7bc20f6..3dc3b3d 100644
--- a/bin/templates/cordova/lib/build.js
+++ b/bin/templates/cordova/lib/build.js
@@ -339,14 +339,19 @@ function parseOpts(options, resolvedTarget) {
                 case 'gradle':
                     ret.buildMethod = option;
                     break;
+                case 'device':
+                case 'emulator':
+                    // Don't need to do anything special to when building for device vs emulator.
+                    // iOS uses this flag to switch on architecture.
+                    break;
                 case 'nobuild' :
                     ret.buildMethod = 'none';
                     break;
                 default :
-                    return Q.reject('Build option \'' + options[i] + '\' not recognized.');
+                    console.warn('Build option \'' + options[i] + '\' not recognized (ignoring).';
             }
         } else {
-            return Q.reject('Build option \'' + options[i] + '\' not recognized.');
+            console.warn('Build option \'' + options[i] + '\' not recognized (ignoring).';
         }
     }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


Mime
View raw message