cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agri...@apache.org
Subject [2/3] android commit: CB-7512 Use aligned apk rather than unaligned apk when sorting
Date Tue, 16 Sep 2014 19:01:14 GMT
CB-7512 Use aligned apk rather than unaligned apk when sorting


Project: http://git-wip-us.apache.org/repos/asf/cordova-android/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-android/commit/a5d300c6
Tree: http://git-wip-us.apache.org/repos/asf/cordova-android/tree/a5d300c6
Diff: http://git-wip-us.apache.org/repos/asf/cordova-android/diff/a5d300c6

Branch: refs/heads/master
Commit: a5d300c6ff7bbcec4bbb982ac7a4195333260941
Parents: 533677d
Author: Andrew Grieve <agrieve@chromium.org>
Authored: Tue Sep 16 14:59:43 2014 -0400
Committer: Andrew Grieve <agrieve@chromium.org>
Committed: Tue Sep 16 14:59:43 2014 -0400

----------------------------------------------------------------------
 bin/templates/cordova/lib/build.js | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-android/blob/a5d300c6/bin/templates/cordova/lib/build.js
----------------------------------------------------------------------
diff --git a/bin/templates/cordova/lib/build.js b/bin/templates/cordova/lib/build.js
index e63e342..3224758 100644
--- a/bin/templates/cordova/lib/build.js
+++ b/bin/templates/cordova/lib/build.js
@@ -38,8 +38,11 @@ function find_files(directory, predicate) {
             p = path.join(directory, p);
             return { p: p, t: fs.statSync(p).mtime };
         }).sort(function(a,b) {
-            return a.t > b.t ? -1 :
-                   a.t < b.t ? 1 : 0;
+            var timeDiff = b.t - a.t;
+            if (timeDiff === 0) {
+                return a.p.length - b.p.length;
+            }
+            return timeDiff;
         }).map(function(p) { return p.p; });
         return candidates;
     } else {
@@ -151,8 +154,9 @@ var builders = {
                 console.error('ERROR : No .apk found in ' + binDir + ' directory');
                 process.exit(2);
             }
-            console.log('Using apk: ' + candidates[0]);
-            return [candidates[0]];
+            var ret = candidates[0];
+            console.log('Using apk: ' + ret);
+            return [ret];
         }
     },
     gradle: {
@@ -245,14 +249,16 @@ var builders = {
             var candidates = find_files(binDir, function(candidate) {
                 // Need to choose between release and debug .apk.
                 if (build_type === 'debug') {
-                    return (path.extname(candidate) == '.apk' && candidate.indexOf('-debug-')
>= 0);
+                    return (path.extname(candidate) == '.apk' && candidate.indexOf('-debug')
>= 0);
                 }
                 if (build_type === 'release') {
-                    return (path.extname(candidate) == '.apk' && candidate.indexOf('-release-')
>= 0);
+                    return (path.extname(candidate) == '.apk' && candidate.indexOf('-release')
>= 0);
                 }
                 return path.extname(candidate) == '.apk';
             });
-            return candidates;
+            var ret = candidates[0];
+            console.log('Using apk: ' + ret);
+            return [ret];
         }
     },
 


Mime
View raw message