cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shaz...@apache.org
Subject git commit: CB-7558 - hasPendingOperation flag in Camera plugin's takePicture should be reversed to fix memory errors
Date Mon, 15 Sep 2014 22:34:58 GMT
Repository: cordova-plugin-camera
Updated Branches:
  refs/heads/master 43cb385f0 -> 513bfde49


CB-7558 - hasPendingOperation flag in Camera plugin's takePicture should be reversed to fix
memory errors

Signed-off-by: Shazron Abdullah <shazron@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-camera/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-camera/commit/513bfde4
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-camera/tree/513bfde4
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-camera/diff/513bfde4

Branch: refs/heads/master
Commit: 513bfde49e4226133c976d53834e11b040950d3e
Parents: 43cb385
Author: Wang Jinggang <kinfkong@126.com>
Authored: Thu Jun 5 15:56:45 2014 +0800
Committer: Shazron Abdullah <shazron@apache.org>
Committed: Mon Sep 15 15:34:18 2014 -0700

----------------------------------------------------------------------
 src/ios/CDVCamera.m | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-camera/blob/513bfde4/src/ios/CDVCamera.m
----------------------------------------------------------------------
diff --git a/src/ios/CDVCamera.m b/src/ios/CDVCamera.m
index c2409be..cb53932 100644
--- a/src/ios/CDVCamera.m
+++ b/src/ios/CDVCamera.m
@@ -82,7 +82,7 @@ static NSSet* org_apache_cordova_validArrowDirections;
     NSString* callbackId = command.callbackId;
     NSArray* arguments = command.arguments;
 
-    self.hasPendingOperation = NO;
+    self.hasPendingOperation = YES;
 
     NSString* sourceTypeString = [arguments objectAtIndex:2];
     UIImagePickerControllerSourceType sourceType = UIImagePickerControllerSourceTypeCamera;
// default
@@ -161,7 +161,7 @@ static NSSet* org_apache_cordova_validArrowDirections;
     } else {
         [self.viewController presentViewController:cameraPicker animated:YES completion:nil];
     }
-    self.hasPendingOperation = YES;
+    self.hasPendingOperation = NO;
 }
 
 - (void)repositionPopover:(CDVInvokedUrlCommand*)command


Mime
View raw message