cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From i..@apache.org
Subject [16/31] android commit: CB-7410 fix the menu test
Date Thu, 11 Sep 2014 15:28:58 GMT
CB-7410 fix the menu test

Need to show the title in order for the options menu button to be visible.


Project: http://git-wip-us.apache.org/repos/asf/cordova-android/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-android/commit/0cde8819
Tree: http://git-wip-us.apache.org/repos/asf/cordova-android/tree/0cde8819
Diff: http://git-wip-us.apache.org/repos/asf/cordova-android/diff/0cde8819

Branch: refs/heads/4.0.x
Commit: 0cde8819cfdfa7df03639b9d3b24f7d2933dee1a
Parents: 07632b0
Author: Marcel Kinard <cmarcelk@gmail.com>
Authored: Fri Aug 29 18:07:29 2014 -0400
Committer: Marcel Kinard <cmarcelk@gmail.com>
Committed: Fri Aug 29 18:07:29 2014 -0400

----------------------------------------------------------------------
 test/assets/www/menus/index.html            | 2 +-
 test/src/org/apache/cordova/test/menus.java | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-android/blob/0cde8819/test/assets/www/menus/index.html
----------------------------------------------------------------------
diff --git a/test/assets/www/menus/index.html b/test/assets/www/menus/index.html
index 58d64c3..ff0b93b 100755
--- a/test/assets/www/menus/index.html
+++ b/test/assets/www/menus/index.html
@@ -33,7 +33,7 @@
         <h4>Deviceready: <span id="deviceready"> &nbsp;</span></h4>
      </div>
      <div id="info">
-     <h4>The menu items should be:</h4>
+     <h4>The options menu items should be:</h4>
      <li>Item1<br>
      <li>Item2<br>
      <li>Item3<br>

http://git-wip-us.apache.org/repos/asf/cordova-android/blob/0cde8819/test/src/org/apache/cordova/test/menus.java
----------------------------------------------------------------------
diff --git a/test/src/org/apache/cordova/test/menus.java b/test/src/org/apache/cordova/test/menus.java
index 12d5230..6d0d3f1 100755
--- a/test/src/org/apache/cordova/test/menus.java
+++ b/test/src/org/apache/cordova/test/menus.java
@@ -28,10 +28,12 @@ import android.view.ContextMenu.ContextMenuInfo;
 import org.apache.cordova.*;
 import org.apache.cordova.LOG;
 
-public class menus extends DroidGap {
+public class menus extends CordovaActivity {
     @Override
     public void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
+        // need the title to be shown for the options menu to be visible
+        preferences.set("showTitle", true);
         super.init();
         super.registerForContextMenu(super.appView);
         super.loadUrl("file:///android_asset/www/menus/index.html");


Mime
View raw message