Return-Path: X-Original-To: apmail-cordova-commits-archive@www.apache.org Delivered-To: apmail-cordova-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0151611C40 for ; Fri, 15 Aug 2014 20:42:42 +0000 (UTC) Received: (qmail 38673 invoked by uid 500); 15 Aug 2014 20:42:41 -0000 Delivered-To: apmail-cordova-commits-archive@cordova.apache.org Received: (qmail 38647 invoked by uid 500); 15 Aug 2014 20:42:41 -0000 Mailing-List: contact commits-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list commits@cordova.apache.org Received: (qmail 38638 invoked by uid 99); 15 Aug 2014 20:42:41 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Aug 2014 20:42:41 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 7670C9C5C29; Fri, 15 Aug 2014 20:42:41 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: purplecabbage@apache.org To: commits@cordova.apache.org Date: Fri, 15 Aug 2014 20:42:42 -0000 Message-Id: <23b33b5536bd40bf82c718e81c3d1938@git.apache.org> In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [2/2] git commit: Fix jshint errors in amazon_fireos_parser : mixed single/double quotes Fix jshint errors in amazon_fireos_parser : mixed single/double quotes Project: http://git-wip-us.apache.org/repos/asf/cordova-lib/repo Commit: http://git-wip-us.apache.org/repos/asf/cordova-lib/commit/c8adbc2a Tree: http://git-wip-us.apache.org/repos/asf/cordova-lib/tree/c8adbc2a Diff: http://git-wip-us.apache.org/repos/asf/cordova-lib/diff/c8adbc2a Branch: refs/heads/master Commit: c8adbc2a0a45eefaae30297f44dabd7d19215518 Parents: ede4a86 Author: Jesse MacFadyen Authored: Fri Aug 15 13:42:52 2014 -0700 Committer: Jesse MacFadyen Committed: Fri Aug 15 13:42:52 2014 -0700 ---------------------------------------------------------------------- .../src/cordova/metadata/amazon_fireos_parser.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cordova-lib/blob/c8adbc2a/cordova-lib/src/cordova/metadata/amazon_fireos_parser.js ---------------------------------------------------------------------- diff --git a/cordova-lib/src/cordova/metadata/amazon_fireos_parser.js b/cordova-lib/src/cordova/metadata/amazon_fireos_parser.js index 4878f4e..517cd49 100644 --- a/cordova-lib/src/cordova/metadata/amazon_fireos_parser.js +++ b/cordova-lib/src/cordova/metadata/amazon_fireos_parser.js @@ -227,8 +227,8 @@ handleIcons: function(config) { // Update the version by changing the AndroidManifest android:versionName var version = config.version(); var versionCode = config.android_versionCode() || default_versionCode(version); - manifest.getroot().attrib["android:versionName"] = version; - manifest.getroot().attrib["android:versionCode"] = versionCode; + manifest.getroot().attrib['android:versionName'] = version; + manifest.getroot().attrib['android:versionCode'] = versionCode; // Update package name by changing the AndroidManifest id and moving the entry class around to the proper package directory var pkg = config.packageName(); @@ -243,22 +243,22 @@ handleIcons: function(config) { if (orientationPref) { switch (orientationPref) { case 'default': - delete act.attrib["android:screenOrientation"]; + delete act.attrib['android:screenOrientation']; break; case 'portrait': - act.attrib["android:screenOrientation"] = 'portrait'; + act.attrib['android:screenOrientation'] = 'portrait'; break; case 'landscape': - act.attrib["android:screenOrientation"] = 'landscape'; + act.attrib['android:screenOrientation'] = 'landscape'; } } // Set android:launchMode in AndroidManifest var androidLaunchModePref = this.findAndroidLaunchModePreference(config); if (androidLaunchModePref) { - act.attrib["android:launchMode"] = androidLaunchModePref; + act.attrib['android:launchMode'] = androidLaunchModePref; } else { // User has (explicitly) set an invalid value for AndroidLaunchMode preference - delete act.attrib["android:launchMode"]; // use Android default value (standard) + delete act.attrib['android:launchMode']; // use Android default value (standard) } // Write out AndroidManifest.xml