Return-Path: X-Original-To: apmail-cordova-commits-archive@www.apache.org Delivered-To: apmail-cordova-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8360E114C9 for ; Thu, 7 Aug 2014 20:16:19 +0000 (UTC) Received: (qmail 85874 invoked by uid 500); 7 Aug 2014 20:16:19 -0000 Delivered-To: apmail-cordova-commits-archive@cordova.apache.org Received: (qmail 85848 invoked by uid 500); 7 Aug 2014 20:16:19 -0000 Mailing-List: contact commits-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list commits@cordova.apache.org Received: (qmail 85839 invoked by uid 99); 7 Aug 2014 20:16:19 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Aug 2014 20:16:19 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 94C5B94A958; Thu, 7 Aug 2014 20:16:17 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: purplecabbage@apache.org To: commits@cordova.apache.org Date: Thu, 07 Aug 2014 20:16:17 -0000 Message-Id: <008f43c91ff841aeaf6a75fd9cbd4696@git.apache.org> In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [2/8] git commit: Style improvements on Manual tests Style improvements on Manual tests Usage of info, which is wired a css class, aimed to only show results. Reorganization of titles and tables. Just organization of labes, and html elements. Removed comment from automated tests. Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-file/repo Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-file/commit/83041f43 Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-file/tree/83041f43 Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-file/diff/83041f43 Branch: refs/heads/master Commit: 83041f438b9f58c5ee3c53496a2e0a41a7bf80ff Parents: 21b568f Author: Martin Gonzalez Authored: Thu Jul 17 16:35:39 2014 -0500 Committer: Martin Gonzalez Committed: Thu Jul 17 16:35:39 2014 -0500 ---------------------------------------------------------------------- test/tests.js | 33 +++++++++++++++++++-------------- 1 file changed, 19 insertions(+), 14 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cordova-plugin-file/blob/83041f43/test/tests.js ---------------------------------------------------------------------- diff --git a/test/tests.js b/test/tests.js index 345e416..ec1a4cf 100644 --- a/test/tests.js +++ b/test/tests.js @@ -998,7 +998,6 @@ exports.defineAutoTests = function () { // create a new directory entry createDirectory(dirName, function (entry) { entry.getParent(function (parent) { - //alert("parent: "+JSON.stringify(parent)); expect(parent).toBeDefined(); expect(parent.fullPath).toCanonicallyMatch(rootPath); // cleanup @@ -3092,12 +3091,12 @@ exports.defineManualTests = function (contentEl, createActionButton) { } function clearLog() { - var log = document.getElementById("log--content"); + var log = document.getElementById("info"); log.innerHTML = ""; } function logMessage(message, color) { - var log = document.getElementById("log--content"); + var log = document.getElementById("info"); var logLine = document.createElement('div'); if (color) { logLine.style.color = color; @@ -3118,28 +3117,34 @@ exports.defineManualTests = function (contentEl, createActionButton) { }; //Add title and align to content - var div = document.createElement('h2'), - content = document.createTextNode('File Systems'); - div.appendChild(content); - content = document.getElementById('content'); - content.setAttribute("align", "center"); - content.appendChild(div); - + var div = document.createElement('h2'); + div.appendChild(document.createTextNode('File Systems')); + div.setAttribute("align", "center"); + contentEl.appendChild(div); + + div = document.createElement('div'); + div.setAttribute("id", "button"); + div.setAttribute("align", "center"); + contentEl.appendChild(div); if (fsRoots.hasOwnProperty(cordova.platformId)) { (fsRoots[cordova.platformId].split(',')).forEach(function (fs) { if (cordova.platformId === 'ios' && fs === 'private') { createActionButton("Test private URL (iOS)", function () { clearLog(); - document.getElementById('log').classList.add('expanded'); testPrivateURL(); - }, 'content'); + }, 'button'); } else { createActionButton(fs, function () { clearLog(); - document.getElementById('log').classList.add('expanded'); resolveFs(fs); - }, 'content'); + }, 'button'); } }); } + + + div = document.createElement('div'); + div.setAttribute("id", "info"); + div.setAttribute("align", "center"); + contentEl.appendChild(div); };