cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jso...@apache.org
Subject git commit: CB-7364 remove duplicate logging initialization for cordova/plugman
Date Thu, 21 Aug 2014 23:13:14 GMT
Repository: cordova-cli
Updated Branches:
  refs/heads/master d4898e769 -> 2f42501bb


CB-7364 remove duplicate logging initialization for cordova/plugman

a4d941f merged events, cordova, and plugman to share a common events implementation,
but it left cli registering them three times


Project: http://git-wip-us.apache.org/repos/asf/cordova-cli/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-cli/commit/2f42501b
Tree: http://git-wip-us.apache.org/repos/asf/cordova-cli/tree/2f42501b
Diff: http://git-wip-us.apache.org/repos/asf/cordova-cli/diff/2f42501b

Branch: refs/heads/master
Commit: 2f42501bb0980981aace939ccd70bcaab2b65f6d
Parents: d4898e7
Author: Josh Soref <jsoref@blackberry.com>
Authored: Thu Aug 21 19:11:54 2014 -0400
Committer: Josh Soref <jsoref@blackberry.com>
Committed: Thu Aug 21 19:11:54 2014 -0400

----------------------------------------------------------------------
 src/cli.js | 28 ----------------------------
 1 file changed, 28 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-cli/blob/2f42501b/src/cli.js
----------------------------------------------------------------------
diff --git a/src/cli.js b/src/cli.js
index a0ccc11..c2b3650 100644
--- a/src/cli.js
+++ b/src/cli.js
@@ -55,33 +55,6 @@ function init() {
     }
 };
 
-/**
- *
- * set up event handlers for logging and results emitted as events.
- */
-function initLogHandlers(args) {
-
-    cordova.on('results', console.log);
-
-    if ( !args.silent ) {
-        cordova.on('log', console.log);
-        cordova.on('warn', console.warn);
-        plugman.on('log', console.log);
-        plugman.on('results', console.log);
-        plugman.on('warn', console.warn);
-    }
-
-};
-
-function initVerboseHandlers() {
-    // Add handlers for verbose logging
-    if (args.verbose) {
-        cordova.on('verbose', console.log);
-        plugman.on('verbose', console.log);
-    }
-};
-
-
 module.exports = cli
 function cli(inputArgs) {
     // When changing command line arguments, update doc/help.txt accordingly.
@@ -119,7 +92,6 @@ function cli(inputArgs) {
     inputArgs = inputArgs || process.argv
 
     init();
-    initLogHandlers(inputArgs);
 
 
 


Mime
View raw message