cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agri...@apache.org
Subject [9/9] android commit: Remove fields from CordovaWebView interface
Date Tue, 24 Jun 2014 19:30:02 GMT
Remove fields from CordovaWebView interface

Fields don't make sense in an interface.


Project: http://git-wip-us.apache.org/repos/asf/cordova-android/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-android/commit/428e1bc1
Tree: http://git-wip-us.apache.org/repos/asf/cordova-android/tree/428e1bc1
Diff: http://git-wip-us.apache.org/repos/asf/cordova-android/diff/428e1bc1

Branch: refs/heads/4.0.x
Commit: 428e1bc14d87b4b9f8bd5c9bfb358a2a15310167
Parents: d66bb84
Author: Andrew Grieve <agrieve@chromium.org>
Authored: Tue Jun 24 15:28:53 2014 -0400
Committer: Andrew Grieve <agrieve@chromium.org>
Committed: Tue Jun 24 15:28:53 2014 -0400

----------------------------------------------------------------------
 framework/src/org/apache/cordova/AndroidWebView.java | 3 +--
 framework/src/org/apache/cordova/CordovaWebView.java | 6 ------
 2 files changed, 1 insertion(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-android/blob/428e1bc1/framework/src/org/apache/cordova/AndroidWebView.java
----------------------------------------------------------------------
diff --git a/framework/src/org/apache/cordova/AndroidWebView.java b/framework/src/org/apache/cordova/AndroidWebView.java
index 4074d21..5fd6495 100755
--- a/framework/src/org/apache/cordova/AndroidWebView.java
+++ b/framework/src/org/apache/cordova/AndroidWebView.java
@@ -69,8 +69,7 @@ import android.widget.FrameLayout;
  */
 public class AndroidWebView extends WebView implements CordovaWebView {
 
-    public static final String TAG = "CordovaWebView";
-    public static final String CORDOVA_VERSION = "4.0.0-dev";
+    public static final String TAG = "AndroidWebView";
 
     private HashSet<Integer> boundKeyCodes = new HashSet<Integer>();
 

http://git-wip-us.apache.org/repos/asf/cordova-android/blob/428e1bc1/framework/src/org/apache/cordova/CordovaWebView.java
----------------------------------------------------------------------
diff --git a/framework/src/org/apache/cordova/CordovaWebView.java b/framework/src/org/apache/cordova/CordovaWebView.java
index 5329ce2..6534a5d 100644
--- a/framework/src/org/apache/cordova/CordovaWebView.java
+++ b/framework/src/org/apache/cordova/CordovaWebView.java
@@ -12,12 +12,6 @@ import android.webkit.WebChromeClient.CustomViewCallback;
 import android.widget.LinearLayout.LayoutParams;
 
 public interface CordovaWebView {
-
-    String OVER_SCROLL_NEVER = null;
-    Object pluginManager = null;
-    Object jsMessageQueue = null;
-
-    public static final String TAG = "CordovaWebView";
     public static final String CORDOVA_VERSION = "4.0.0-dev";
 
     View getView();


Mime
View raw message