cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agri...@apache.org
Subject [1/3] git commit: Fix jshint errors
Date Mon, 05 May 2014 19:39:19 GMT
Repository: cordova-app-harness
Updated Branches:
  refs/heads/master 748924fcd -> 161eb779f


Fix jshint errors


Project: http://git-wip-us.apache.org/repos/asf/cordova-app-harness/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-app-harness/commit/419236aa
Tree: http://git-wip-us.apache.org/repos/asf/cordova-app-harness/tree/419236aa
Diff: http://git-wip-us.apache.org/repos/asf/cordova-app-harness/diff/419236aa

Branch: refs/heads/master
Commit: 419236aa8e73bc624769f81632d1c49d04573d4b
Parents: 748924f
Author: Andrew Grieve <agrieve@chromium.org>
Authored: Mon May 5 10:56:49 2014 -0400
Committer: Andrew Grieve <agrieve@chromium.org>
Committed: Mon May 5 10:56:49 2014 -0400

----------------------------------------------------------------------
 www/cdvah/js/AppsService.js    | 4 ++--
 www/cdvah/js/CrxInstaller.js   | 4 ++--
 www/cdvah/js/ServeInstaller.js | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-app-harness/blob/419236aa/www/cdvah/js/AppsService.js
----------------------------------------------------------------------
diff --git a/www/cdvah/js/AppsService.js b/www/cdvah/js/AppsService.js
index 81ea24e..1b781d7 100644
--- a/www/cdvah/js/AppsService.js
+++ b/www/cdvah/js/AppsService.js
@@ -82,10 +82,10 @@
                 });
             },
 
-            addApp : function(installerType, appUrl, opt_appId) {
+            addApp : function(installerType, appUrl, /*optional*/ appId) {
                 var installerFactory = _installerFactories[installerType];
                 return initHandlers().then(function() {
-                    return installerFactory.createFromUrl(appUrl, opt_appId);
+                    return installerFactory.createFromUrl(appUrl, appId);
                 }).then(function(installer) {
                     _installers.push(installer);
                     return writeAppsJson()

http://git-wip-us.apache.org/repos/asf/cordova-app-harness/blob/419236aa/www/cdvah/js/CrxInstaller.js
----------------------------------------------------------------------
diff --git a/www/cdvah/js/CrxInstaller.js b/www/cdvah/js/CrxInstaller.js
index 6861964..e905c4c 100644
--- a/www/cdvah/js/CrxInstaller.js
+++ b/www/cdvah/js/CrxInstaller.js
@@ -108,9 +108,9 @@
 
         AppsService.registerInstallerFactory({
             type: 'crx',
-            createFromUrl: function(url, opt_appId) {
+            createFromUrl: function(url, /*optional*/appId) {
                 url = urlCleanup(url);
-                return $q.when(new CrxInstaller(url, opt_appId || 'New Chrome App'));
+                return $q.when(new CrxInstaller(url, appId || 'New Chrome App'));
             },
 
             createFromJson: function(url, appId) {

http://git-wip-us.apache.org/repos/asf/cordova-app-harness/blob/419236aa/www/cdvah/js/ServeInstaller.js
----------------------------------------------------------------------
diff --git a/www/cdvah/js/ServeInstaller.js b/www/cdvah/js/ServeInstaller.js
index 703a885..b9a893c 100644
--- a/www/cdvah/js/ServeInstaller.js
+++ b/www/cdvah/js/ServeInstaller.js
@@ -158,13 +158,13 @@
             });
         };
 
-        function createFromUrl(url, opt_appId) {
+        function createFromUrl(url, /*option*/ appId) {
             // Strip platform and trailing slash if they exist.
             url = urlCleanup(url);
             // Fetch config.xml.
             return fetchMetaServeData(url)
             .then(function(meta) {
-                return new ServeInstaller(meta.url, opt_appId || meta.appId);
+                return new ServeInstaller(meta.url, appId || meta.appId);
             });
         }
 


Mime
View raw message