Return-Path: X-Original-To: apmail-cordova-commits-archive@www.apache.org Delivered-To: apmail-cordova-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 638E110CCD for ; Thu, 3 Apr 2014 06:07:49 +0000 (UTC) Received: (qmail 62865 invoked by uid 500); 3 Apr 2014 06:07:46 -0000 Delivered-To: apmail-cordova-commits-archive@cordova.apache.org Received: (qmail 62765 invoked by uid 500); 3 Apr 2014 06:07:46 -0000 Mailing-List: contact commits-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list commits@cordova.apache.org Received: (qmail 62726 invoked by uid 99); 3 Apr 2014 06:07:44 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Apr 2014 06:07:44 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 3BB859394F4; Thu, 3 Apr 2014 06:07:44 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: naika@apache.org To: commits@cordova.apache.org Date: Thu, 03 Apr 2014 06:07:46 -0000 Message-Id: <95b58ce4e4ac46a78c38e4f30a5d9505@git.apache.org> In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [3/4] git commit: Remove incorrect usage of AlertDialog.Builder.create Remove incorrect usage of AlertDialog.Builder.create AlertDialog.Builder.show() will create an AlertDialog before it show. This is the source code snippet: /** * Creates a {@link AlertDialog} with the arguments supplied to this builder and * {@link Dialog#show()}'s the dialog. */ public AlertDialog show() { AlertDialog dialog = create(); dialog.show(); return dialog; } github: close #96 Project: http://git-wip-us.apache.org/repos/asf/cordova-amazon-fireos/repo Commit: http://git-wip-us.apache.org/repos/asf/cordova-amazon-fireos/commit/bece02e8 Tree: http://git-wip-us.apache.org/repos/asf/cordova-amazon-fireos/tree/bece02e8 Diff: http://git-wip-us.apache.org/repos/asf/cordova-amazon-fireos/diff/bece02e8 Branch: refs/heads/master Commit: bece02e894f67f11d1c46f4d865123b5d5ed9e97 Parents: 5e9cb8f Author: hadeslee Authored: Fri Mar 21 12:06:23 2014 +0800 Committer: Archana Naik Committed: Wed Apr 2 13:31:04 2014 -0700 ---------------------------------------------------------------------- framework/src/org/apache/cordova/CordovaChromeClient.java | 3 --- 1 file changed, 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cordova-amazon-fireos/blob/bece02e8/framework/src/org/apache/cordova/CordovaChromeClient.java ---------------------------------------------------------------------- diff --git a/framework/src/org/apache/cordova/CordovaChromeClient.java b/framework/src/org/apache/cordova/CordovaChromeClient.java index 86e20f3..6de43b6 100755 --- a/framework/src/org/apache/cordova/CordovaChromeClient.java +++ b/framework/src/org/apache/cordova/CordovaChromeClient.java @@ -150,7 +150,6 @@ public class CordovaChromeClient extends AmazonWebChromeClient { return true; } }); - dlg.create(); dlg.show(); return true; } @@ -203,7 +202,6 @@ public class CordovaChromeClient extends AmazonWebChromeClient { return true; } }); - dlg.create(); dlg.show(); return true; } @@ -300,7 +298,6 @@ public class CordovaChromeClient extends AmazonWebChromeClient { res.cancel(); } }); - dlg.create(); dlg.show(); } return true;