cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabb...@apache.org
Subject git commit: Windows 8.1 update breaks app manifest parser
Date Mon, 28 Apr 2014 18:17:29 GMT
Repository: cordova-cli
Updated Branches:
  refs/heads/master eb7f6791a -> df5101d2f


Windows 8.1 update breaks app manifest parser

The powers-that-be at Microsoft decided to add another namespace to the package.appxmanifest
when I updated my Windows 8 app to Windows 8.1. The Package/Applications/Application/VisualElements
element now has a namespace prefix of "m2:" which causes an error during project preparation.
This commit contains a quick, low-risk update to accommodate that change.

Project: http://git-wip-us.apache.org/repos/asf/cordova-cli/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-cli/commit/df5101d2
Tree: http://git-wip-us.apache.org/repos/asf/cordova-cli/tree/df5101d2
Diff: http://git-wip-us.apache.org/repos/asf/cordova-cli/diff/df5101d2

Branch: refs/heads/master
Commit: df5101d2fcd2ba7a6ad44578988c946b01434493
Parents: eb7f679
Author: Aaron Newcomer <aaron.newcomer@evostrat.com>
Authored: Mon Apr 28 13:05:53 2014 -0500
Committer: Aaron Newcomer <aaron.newcomer@evostrat.com>
Committed: Mon Apr 28 13:05:53 2014 -0500

----------------------------------------------------------------------
 src/metadata/windows8_parser.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-cli/blob/df5101d2/src/metadata/windows8_parser.js
----------------------------------------------------------------------
diff --git a/src/metadata/windows8_parser.js b/src/metadata/windows8_parser.js
index 2245ff4..9502974 100644
--- a/src/metadata/windows8_parser.js
+++ b/src/metadata/windows8_parser.js
@@ -111,7 +111,7 @@ module.exports.prototype = {
                 app['attrib']['Id'] = pkgName;
             }
 
-            var visualElems = manifest.find('.//VisualElements');
+            var visualElems = manifest.find('.//VisualElements') || manifest.find('.//m2:VisualElements');
 
             if(visualElems) {
                 var displayName = visualElems['attrib']['DisplayName'];


Mime
View raw message