cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabb...@apache.org
Subject [10/13] git commit: projectReference.uninstall has to generate the plugin_dir because it is not passed to uninstall methods
Date Thu, 06 Mar 2014 00:13:37 GMT
projectReference.uninstall has to generate the plugin_dir because it is not passed to uninstall
methods


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugman/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugman/commit/64de69a1
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugman/tree/64de69a1
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugman/diff/64de69a1

Branch: refs/heads/master
Commit: 64de69a1394fd9dc7a59c28d891357a2792342c2
Parents: dc6e49f
Author: Jesse MacFadyen <purplecabbage@gmail.com>
Authored: Wed Mar 5 14:58:37 2014 -0800
Committer: Jesse MacFadyen <purplecabbage@gmail.com>
Committed: Wed Mar 5 14:58:37 2014 -0800

----------------------------------------------------------------------
 src/platforms/windows8.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugman/blob/64de69a1/src/platforms/windows8.js
----------------------------------------------------------------------
diff --git a/src/platforms/windows8.js b/src/platforms/windows8.js
index f859914..287c048 100644
--- a/src/platforms/windows8.js
+++ b/src/platforms/windows8.js
@@ -116,9 +116,11 @@ module.exports = {
             // technically it is not possible to get here without isCustom == true -jm
             // var isCustom = el.attrib.custom == "true"; 
             var type = el.attrib["type"];
+            // unfortunately we have to generate the plugin_dir path because it is not passed
to uninstall
+            var plugin_dir = path.join(project_dir,"cordova/plugins",plugin_id,src);
 
             if(type == "projectReference") {
-                project_file.removeProjectReference(path.join(plugin_dir,src));
+                project_file.removeProjectReference(plugin_dir);
             }
             else {
                 // if(isCustom) {  }  


Mime
View raw message