cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agri...@apache.org
Subject android commit: Remove incorrect usage of AlertDialog.Builder.create
Date Fri, 28 Mar 2014 17:41:57 GMT
Repository: cordova-android
Updated Branches:
  refs/heads/master 9a00ccdac -> b715d2038


Remove incorrect usage of AlertDialog.Builder.create

AlertDialog.Builder.show() will create an AlertDialog before it show. This is the source code
snippet:

        /**
         * Creates a {@link AlertDialog} with the arguments supplied to this builder and
         * {@link Dialog#show()}'s the dialog.
         */
        public AlertDialog show() {
            AlertDialog dialog = create();
            dialog.show();
            return dialog;
        }

github: close #96


Project: http://git-wip-us.apache.org/repos/asf/cordova-android/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-android/commit/b715d203
Tree: http://git-wip-us.apache.org/repos/asf/cordova-android/tree/b715d203
Diff: http://git-wip-us.apache.org/repos/asf/cordova-android/diff/b715d203

Branch: refs/heads/master
Commit: b715d20385a3932dd687460f90db44610d833ad2
Parents: 9a00ccd
Author: hadeslee <hadeslee@vip.qq.com>
Authored: Fri Mar 21 12:06:23 2014 +0800
Committer: Andrew Grieve <agrieve@chromium.org>
Committed: Fri Mar 28 13:40:43 2014 -0400

----------------------------------------------------------------------
 framework/src/org/apache/cordova/CordovaChromeClient.java | 3 ---
 1 file changed, 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-android/blob/b715d203/framework/src/org/apache/cordova/CordovaChromeClient.java
----------------------------------------------------------------------
diff --git a/framework/src/org/apache/cordova/CordovaChromeClient.java b/framework/src/org/apache/cordova/CordovaChromeClient.java
index 5977e00..54c8948 100755
--- a/framework/src/org/apache/cordova/CordovaChromeClient.java
+++ b/framework/src/org/apache/cordova/CordovaChromeClient.java
@@ -139,7 +139,6 @@ public class CordovaChromeClient extends WebChromeClient {
                     return true;
             }
         });
-        dlg.create();
         dlg.show();
         return true;
     }
@@ -188,7 +187,6 @@ public class CordovaChromeClient extends WebChromeClient {
                     return true;
             }
         });
-        dlg.create();
         dlg.show();
         return true;
     }
@@ -280,7 +278,6 @@ public class CordovaChromeClient extends WebChromeClient {
                             res.cancel();
                         }
                     });
-            dlg.create();
             dlg.show();
         }
         return true;


Mime
View raw message