cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a...@apache.org
Subject [3/7] js commit: CB-5438 Exclude local symlinks from jshint
Date Thu, 06 Feb 2014 03:25:30 GMT
CB-5438 Exclude local symlinks from jshint

Both /src/test/androidexec.js and /src/test/iosexec.js are symlinks to
/src/android/exec.js and /src/ios/exec.js

Symlinks don't work on the Windows platform and are represented there as
a text file with the contents being a text description of where it
should be pointing at.

The problem is that the jshint task of the build tries to parse those
'text' files as js files, which fails for obvious reasons.

My solution is to explicitly exclude those 2 symlink files from the
jshint task. The files they point at are included in the src/**/*.js
jshint src setting, so they will get checked anyway.

Now we can succesfully run grunt build on Windows.


Project: http://git-wip-us.apache.org/repos/asf/cordova-js/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-js/commit/a85f693c
Tree: http://git-wip-us.apache.org/repos/asf/cordova-js/tree/a85f693c
Diff: http://git-wip-us.apache.org/repos/asf/cordova-js/diff/a85f693c

Branch: refs/heads/browserify
Commit: a85f693ca5d15cd5c5204f81c1542100fac13300
Parents: ba3190d
Author: Bas Bosman <sbg.bosman@mindef.nl>
Authored: Sun Jan 26 15:43:31 2014 +0100
Committer: Bas Bosman <sbg.bosman@mindef.nl>
Committed: Sun Jan 26 15:43:31 2014 +0100

----------------------------------------------------------------------
 Gruntfile.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-js/blob/a85f693c/Gruntfile.js
----------------------------------------------------------------------
diff --git a/Gruntfile.js b/Gruntfile.js
index 683c9de..b1e456a 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -38,7 +38,7 @@ module.exports = function(grunt) {
             options: {
                 jshintrc: '.jshintrc',
             },
-            src: [ 'src/**/*.js' ]
+            src: ['src/**/*.js', '!src/test/androidexec.js', '!src/test/iosexec.js']
         },
     });
 


Mime
View raw message