cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agri...@apache.org
Subject git commit: CB-5590 Have config.xml version map to CFBundleShortVersionString instead of CFBundleVersion
Date Tue, 21 Jan 2014 20:54:53 GMT
Updated Branches:
  refs/heads/master 8aecd4966 -> 584338bba


CB-5590 Have config.xml version map to CFBundleShortVersionString instead of CFBundleVersion


Project: http://git-wip-us.apache.org/repos/asf/cordova-cli/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-cli/commit/584338bb
Tree: http://git-wip-us.apache.org/repos/asf/cordova-cli/tree/584338bb
Diff: http://git-wip-us.apache.org/repos/asf/cordova-cli/diff/584338bb

Branch: refs/heads/master
Commit: 584338bba4925bfd1f36ae8e85525bc9103f2e7a
Parents: 8aecd49
Author: Andrew Grieve <agrieve@chromium.org>
Authored: Tue Jan 21 15:53:25 2014 -0500
Committer: Andrew Grieve <agrieve@chromium.org>
Committed: Tue Jan 21 15:54:44 2014 -0500

----------------------------------------------------------------------
 spec/metadata/ios_parser.spec.js | 2 +-
 src/metadata/ios_parser.js       | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-cli/blob/584338bb/spec/metadata/ios_parser.spec.js
----------------------------------------------------------------------
diff --git a/spec/metadata/ios_parser.spec.js b/spec/metadata/ios_parser.spec.js
index ba9a1da..4ee292c 100644
--- a/spec/metadata/ios_parser.spec.js
+++ b/spec/metadata/ios_parser.spec.js
@@ -167,7 +167,7 @@ describe('ios project parser', function () {
             });
             it('should write out the app version to info plist as CFBundleVersion', function(done)
{
                 wrapper(p.update_from_config(cfg), done, function() {
-                    expect(plist_build.mostRecentCall.args[0].CFBundleVersion).toEqual('one
point oh');
+                    expect(plist_build.mostRecentCall.args[0].CFBundleShortVersionString).toEqual('one
point oh');
                 });
             });
         });

http://git-wip-us.apache.org/repos/asf/cordova-cli/blob/584338bb/src/metadata/ios_parser.js
----------------------------------------------------------------------
diff --git a/src/metadata/ios_parser.js b/src/metadata/ios_parser.js
index 3bc0a7b..36172e9 100644
--- a/src/metadata/ios_parser.js
+++ b/src/metadata/ios_parser.js
@@ -66,7 +66,9 @@ module.exports.prototype = {
         infoPlist['CFBundleIdentifier'] = pkg;
 
         // Update version (bundle version)
-        infoPlist['CFBundleVersion'] = version;
+        infoPlist['CFBundleShortVersionString'] = version;
+        // TODO: add a way to update infoPlist['CFBundleVersion'].
+
         var info_contents = plist.build(infoPlist);
         info_contents = info_contents.replace(/<string>[\s\r\n]*<\/string>/g,'<string></string>');
         fs.writeFileSync(plistFile, info_contents, 'utf-8');


Mime
View raw message