cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agri...@apache.org
Subject [3/3] git commit: CB-4871 Delete ripple command.
Date Thu, 09 Jan 2014 16:50:04 GMT
CB-4871 Delete ripple command.

This saves 11 megs from node_modules.
- The command was undocumented and reported broken (CB-5075)

If we add back the command, we should ask users to install ripple
separately instead of using node_modules.


Project: http://git-wip-us.apache.org/repos/asf/cordova-cli/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-cli/commit/57c0fbd2
Tree: http://git-wip-us.apache.org/repos/asf/cordova-cli/tree/57c0fbd2
Diff: http://git-wip-us.apache.org/repos/asf/cordova-cli/diff/57c0fbd2

Branch: refs/heads/master
Commit: 57c0fbd2586e4d134fdeb19b6c51f22ebc710417
Parents: 69738ca
Author: Andrew Grieve <agrieve@chromium.org>
Authored: Thu Jan 9 11:48:32 2014 -0500
Committer: Andrew Grieve <agrieve@chromium.org>
Committed: Thu Jan 9 11:48:32 2014 -0500

----------------------------------------------------------------------
 cordova.js    |  1 -
 package.json  |  1 -
 src/ripple.js | 52 ----------------------------------------------------
 3 files changed, 54 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-cli/blob/57c0fbd2/cordova.js
----------------------------------------------------------------------
diff --git a/cordova.js b/cordova.js
index eb0c788..45ad0c2 100644
--- a/cordova.js
+++ b/cordova.js
@@ -46,7 +46,6 @@ addModuleProperty(module, 'build', './src/build', true);
 addModuleProperty(module, 'help', './src/help');
 addModuleProperty(module, 'config', './src/config');
 addModuleProperty(module, 'create', './src/create', true);
-addModuleProperty(module, 'ripple', './src/ripple');
 addModuleProperty(module, 'emulate', './src/emulate', true);
 addModuleProperty(module, 'plugin', './src/plugin', true);
 addModuleProperty(module, 'plugins', './src/plugin', true);

http://git-wip-us.apache.org/repos/asf/cordova-cli/blob/57c0fbd2/package.json
----------------------------------------------------------------------
diff --git a/package.json b/package.json
index 4663e6e..ad63a4f 100644
--- a/package.json
+++ b/package.json
@@ -34,7 +34,6 @@
     "xcode": "0.6.2",
     "shelljs": "0.1.2",
     "request": "2.22.0",
-    "ripple-emulator": "0.9.18",
     "semver": "1.1.0",
     "tar": "0.1.x",
     "npm": "1.3.x",

http://git-wip-us.apache.org/repos/asf/cordova-cli/blob/57c0fbd2/src/ripple.js
----------------------------------------------------------------------
diff --git a/src/ripple.js b/src/ripple.js
deleted file mode 100644
index d576d58..0000000
--- a/src/ripple.js
+++ /dev/null
@@ -1,52 +0,0 @@
-/**
-    Licensed to the Apache Software Foundation (ASF) under one
-    or more contributor license agreements.  See the NOTICE file
-    distributed with this work for additional information
-    regarding copyright ownership.  The ASF licenses this file
-    to you under the Apache License, Version 2.0 (the
-    "License"); you may not use this file except in compliance
-    with the License.  You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-    Unless required by applicable law or agreed to in writing,
-    software distributed under the License is distributed on an
-    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-    KIND, either express or implied.  See the License for the
-    specific language governing permissions and limitations
-    under the License.
-*/
-var serve = require('./serve'),
-    ripple = require('ripple-emulator'),
-    open = require('open');
-
-module.exports = function (platform, port) {
-    port = port || 8000;
-
-    serve.config(platform, port, function (cfg) {
-        ripple.emulate.start({
-            path: cfg.paths,
-            port: port
-        });
-
-        var device;
-
-        switch (platform) {
-        case "blackberry10":
-            device = "Z10";
-            break;
-        case "ios":
-            device = "IPhone5";
-            break;
-        case "android":
-            device = "NexusS";
-            break;
-        default:
-            device = "XVGA";
-            break;
-        }
-
-        var uri = "http://localhost:" + port + "?enableripple=cordova-2.0.0-" + device;
-        open(uri);
-    });
-};


Mime
View raw message