cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bows...@apache.org
Subject [27/50] [abbrv] git commit: Moving the console.log out of run() method
Date Wed, 22 Jan 2014 19:38:38 GMT
Moving the console.log out of run() method

Since cordova-cli calls the check_req library run() method, we do not
want to always console.log on success in there (not usually a useful side
effect).


Project: http://git-wip-us.apache.org/repos/asf/cordova-amazon-fireos/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-amazon-fireos/commit/a4029b23
Tree: http://git-wip-us.apache.org/repos/asf/cordova-amazon-fireos/tree/a4029b23
Diff: http://git-wip-us.apache.org/repos/asf/cordova-amazon-fireos/diff/a4029b23

Branch: refs/heads/master
Commit: a4029b23f4bc9714830458201ed174427cc870b8
Parents: 648c5d6
Author: Michal Mocny <mmocny@gmail.com>
Authored: Fri Nov 29 14:39:09 2013 -0500
Committer: Joe Bowser <bowserj@apache.org>
Committed: Wed Jan 22 11:37:18 2014 -0800

----------------------------------------------------------------------
 bin/check_reqs        | 13 ++++++++-----
 bin/lib/check_reqs.js |  2 +-
 2 files changed, 9 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-amazon-fireos/blob/a4029b23/bin/check_reqs
----------------------------------------------------------------------
diff --git a/bin/check_reqs b/bin/check_reqs
index 2ac8752..372a383 100755
--- a/bin/check_reqs
+++ b/bin/check_reqs
@@ -21,8 +21,11 @@
 
 var check_reqs = require('./lib/check_reqs');
 
-check_reqs.run().done(null, function(err) {
-    console.log(err);
-    process.exit(2);
-});
-
+check_reqs.run().done(
+    function success() {
+        console.log('Looks like your environment fully supports cordova-android development!');
+    }, function fail(err) {
+        console.log(err);
+        process.exit(2);
+    }
+);

http://git-wip-us.apache.org/repos/asf/cordova-amazon-fireos/blob/a4029b23/bin/lib/check_reqs.js
----------------------------------------------------------------------
diff --git a/bin/lib/check_reqs.js b/bin/lib/check_reqs.js
index 266bec9..807086e 100644
--- a/bin/lib/check_reqs.js
+++ b/bin/lib/check_reqs.js
@@ -89,5 +89,5 @@ module.exports.check_android = function() {
 
 // Returns a promise.
 module.exports.run = function() {
-    return Q.all([this.check_ant(), this.check_java, this.check_android()]);
+    return Q.all([this.check_ant(), this.check_java(), this.check_android()]);
 }


Mime
View raw message