cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marc...@apache.org
Subject git commit: CB-5688: check for required args
Date Fri, 20 Dec 2013 18:28:23 GMT
Updated Branches:
  refs/heads/master 6ca5cf9b2 -> 1f2347616


CB-5688: check for required args


Project: http://git-wip-us.apache.org/repos/asf/cordova-cli/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-cli/commit/1f234761
Tree: http://git-wip-us.apache.org/repos/asf/cordova-cli/tree/1f234761
Diff: http://git-wip-us.apache.org/repos/asf/cordova-cli/diff/1f234761

Branch: refs/heads/master
Commit: 1f234761639d0b0cdac0d23db8e9ff2a3bd5ecad
Parents: 6ca5cf9
Author: Marcel Kinard <cmarcelk@gmail.com>
Authored: Fri Dec 20 13:24:45 2013 -0500
Committer: Marcel Kinard <cmarcelk@gmail.com>
Committed: Fri Dec 20 13:24:45 2013 -0500

----------------------------------------------------------------------
 src/platform.js | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-cli/blob/1f234761/src/platform.js
----------------------------------------------------------------------
diff --git a/src/platform.js b/src/platform.js
index ff6a319..682cfb7 100644
--- a/src/platform.js
+++ b/src/platform.js
@@ -42,7 +42,7 @@ module.exports = function platform(command, targets) {
         var err;
         targets.forEach(function(t) {
             if (!(t in platforms)) {
-                err = new Error('Platform "' + t + '" not recognized as core cordova platform.');
+                err = new Error('Platform "' + t + '" not recognized as a core cordova platform.
See "platform list".');
             }
         });
         if (err) return Q.reject(err);
@@ -60,6 +60,9 @@ module.exports = function platform(command, targets) {
 
     switch(command) {
         case 'add':
+            if (!targets || !targets.length) {
+                return Q.reject(new Error('No platform specified. Please specify a platform
to add. See "platform list".'));
+            }
             var config_json = config.read(projectRoot);
 
             return hooks.fire('before_platform_add', opts)
@@ -83,6 +86,9 @@ module.exports = function platform(command, targets) {
             break;
         case 'rm':
         case 'remove':
+            if (!targets || !targets.length) {
+                return Q.reject(new Error('No platform[s] specified. Please specify platform[s]
to remove. See "platform list".'));
+            }
             return hooks.fire('before_platform_rm', opts)
             .then(function() {
                 targets.forEach(function(target) {
@@ -100,14 +106,14 @@ module.exports = function platform(command, targets) {
         case 'up':
             // Shell out to the update script provided by the named platform.
             if (!targets || !targets.length) {
-                return Q.reject(new Error('No platform provided. Please specify a platform
to update.'));
+                return Q.reject(new Error('No platform specified. Please specify a platform
to update. See "platform list".'));
             } else if (targets.length > 1) {
                 return Q.reject(new Error('Platform update can only be executed on one platform
at a time.'));
             } else {
                 var plat = targets[0];
                 var installed_platforms = cordova_util.listPlatforms(projectRoot);
                 if (installed_platforms.indexOf(plat) < 0) {
-                    return Q.reject(new Error('Platform "' + plat + '" is not installed.'));
+                    return Q.reject(new Error('Platform "' + plat + '" is not installed.
See "platform list".'));
                 }
 
                 // First, lazy_load the latest version.


Mime
View raw message