cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agri...@apache.org
Subject [1/2] git commit: Remove dead code
Date Mon, 23 Dec 2013 21:21:36 GMT
Updated Branches:
  refs/heads/master 837e8e367 -> 8bde8edfa


Remove dead code


Project: http://git-wip-us.apache.org/repos/asf/cordova-cli/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-cli/commit/0a9020c7
Tree: http://git-wip-us.apache.org/repos/asf/cordova-cli/tree/0a9020c7
Diff: http://git-wip-us.apache.org/repos/asf/cordova-cli/diff/0a9020c7

Branch: refs/heads/master
Commit: 0a9020c70da8484365896c60ea1f977ce08c9c0b
Parents: 837e8e3
Author: Andrew Grieve <agrieve@chromium.org>
Authored: Mon Dec 23 15:11:54 2013 -0500
Committer: Andrew Grieve <agrieve@chromium.org>
Committed: Mon Dec 23 15:13:31 2013 -0500

----------------------------------------------------------------------
 src/metadata/ios_parser.js | 41 -----------------------------------------
 1 file changed, 41 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-cli/blob/0a9020c7/src/metadata/ios_parser.js
----------------------------------------------------------------------
diff --git a/src/metadata/ios_parser.js b/src/metadata/ios_parser.js
index fcfa243..21d0d5b 100644
--- a/src/metadata/ios_parser.js
+++ b/src/metadata/ios_parser.js
@@ -22,30 +22,11 @@ var fs            = require('fs'),
     util          = require('../util'),
     events        = require('../events'),
     shell         = require('shelljs'),
-    child_process = require('child_process'),
     plist         = require('plist'),
-    semver        = require('semver'),
     Q             = require('q'),
     config_parser = require('../config_parser'),
     config        = require('../config');
 
-var MIN_XCODE_VERSION = '>=4.5.x';
-
-var default_prefs = {
-    "KeyboardDisplayRequiresUserAction":"true",
-    "SuppressesIncrementalRendering":"false",
-    "UIWebViewBounce":"true",
-    "TopActivityIndicator":"gray",
-    "EnableLocation":"false",
-    "EnableViewportScale":"false",
-    "AutoHideSplashScreen":"true",
-    "ShowSplashScreenSpinner":"true",
-    "MediaPlaybackRequiresUserAction":"false",
-    "AllowInlineMediaPlayback":"false",
-    "OpenAllWhitelistURLsInWebView":"false",
-    "BackupWebStorage":"cloud"
-};
-
 module.exports = function ios_parser(project) {
     try {
         var xcodeproj_dir = fs.readdirSync(project).filter(function(e) { return e.match(/\.xcodeproj$/i);
})[0];
@@ -66,28 +47,6 @@ module.exports = function ios_parser(project) {
 module.exports.check_requirements = function(project_root) {
     // Rely on platform's bin/create script to check requirements.
     return Q(true);
-    
-    events.emit('log', 'Checking iOS requirements...');
-    // Check xcode + version.
-    var command = 'xcodebuild -version';
-    events.emit('verbose', 'Running "' + command + '" (output to follow)');
-    var d = Q.defer();
-    
-    child_process.exec(command, function(err, output, stderr) {
-        events.emit('verbose', output+stderr);
-        if (err || stderr) {
-            d.reject(new Error('Xcode is (probably) not installed, specifically the command
`xcodebuild` is unavailable or erroring out. Output of `'+command+'` is: ' + output + stderr));
-        } else {
-            var xc_version = output.split('\n')[0].split(' ')[1];
-            if(xc_version.split('.').length === 2){
-                xc_version += '.0';
-            }
-            if (!semver.satisfies(xc_version, MIN_XCODE_VERSION)) {
-                d.reject(new Error('Xcode version installed is too old. Minimum: ' + MIN_XCODE_VERSION
+ ', yours: ' + xc_version));
-            } else d.resolve();
-        }
-    });
-    return d.promise;
 };
 
 module.exports.prototype = {


Mime
View raw message