cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabb...@apache.org
Subject git commit: CB-5076 String.Format issue causing exception in exception handler
Date Mon, 04 Nov 2013 20:42:49 GMT
Updated Branches:
  refs/heads/master befa33002 -> 254883a62


CB-5076 String.Format issue causing exception in exception handler


Project: http://git-wip-us.apache.org/repos/asf/cordova-wp8/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-wp8/commit/254883a6
Tree: http://git-wip-us.apache.org/repos/asf/cordova-wp8/tree/254883a6
Diff: http://git-wip-us.apache.org/repos/asf/cordova-wp8/diff/254883a6

Branch: refs/heads/master
Commit: 254883a62079039e88ef549346a1a0ba00159779
Parents: befa330
Author: purplecabbage <purplecabbage@gmail.com>
Authored: Mon Nov 4 12:42:33 2013 -0800
Committer: purplecabbage <purplecabbage@gmail.com>
Committed: Mon Nov 4 12:42:33 2013 -0800

----------------------------------------------------------------------
 wp7/template/cordovalib/NativeExecution.cs | 21 +++++----------------
 wp8/template/cordovalib/NativeExecution.cs | 21 +++++----------------
 2 files changed, 10 insertions(+), 32 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-wp8/blob/254883a6/wp7/template/cordovalib/NativeExecution.cs
----------------------------------------------------------------------
diff --git a/wp7/template/cordovalib/NativeExecution.cs b/wp7/template/cordovalib/NativeExecution.cs
index decc51d..c8ec1bd 100644
--- a/wp7/template/cordovalib/NativeExecution.cs
+++ b/wp7/template/cordovalib/NativeExecution.cs
@@ -1,10 +1,10 @@
-/*  
+/*
 	Licensed under the Apache License, Version 2.0 (the "License");
 	you may not use this file except in compliance with the License.
 	You may obtain a copy of the License at
-	
+
 	http://www.apache.org/licenses/LICENSE-2.0
-	
+
 	Unless required by applicable law or agreed to in writing, software
 	distributed under the License is distributed on an "AS IS" BASIS,
 	WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -34,7 +34,7 @@ namespace WPCordovaClassLib.Cordova
         private readonly WebBrowser webBrowser;
 
         /// <summary>
-        /// Creates new instance of a NativeExecution class. 
+        /// Creates new instance of a NativeExecution class.
         /// </summary>
         /// <param name="browser">Reference to web part where application is hosted</param>
         public NativeExecution(ref WebBrowser browser)
@@ -133,24 +133,13 @@ namespace WPCordovaClassLib.Cordova
                     }
                 };
 
-                //if ((bc is File) || (bc is Accelerometer))
-                //{
-                //    // Due to some issues with the IsolatedStorage in current version of
WP8 SDK we have to run all File Api commands synchronously.
-                //    // TODO: test this in WP8 RTM
-                //    methodInvokation.Invoke();
-                //}
-                //else
-                //{
-                //    new Thread(methodInvokation).Start();
-                //}
-
                 new Thread(methodInvokation).Start();
 
             }
             catch (Exception ex)
             {
                 // ERROR
-                Debug.WriteLine(String.Format("ERROR: Unable to execute command :: {0}:{1}:{3}
",
+                Debug.WriteLine(String.Format("ERROR: Unable to execute command :: {0}:{1}:{2}
",
                     commandCallParams.Service, commandCallParams.Action, ex.Message));
 
                 this.OnCommandResult(commandCallParams.CallbackId, new PluginResult(PluginResult.Status.ERROR));

http://git-wip-us.apache.org/repos/asf/cordova-wp8/blob/254883a6/wp8/template/cordovalib/NativeExecution.cs
----------------------------------------------------------------------
diff --git a/wp8/template/cordovalib/NativeExecution.cs b/wp8/template/cordovalib/NativeExecution.cs
index 45ed7aa..c8ec1bd 100644
--- a/wp8/template/cordovalib/NativeExecution.cs
+++ b/wp8/template/cordovalib/NativeExecution.cs
@@ -1,10 +1,10 @@
-/*  
+/*
 	Licensed under the Apache License, Version 2.0 (the "License");
 	you may not use this file except in compliance with the License.
 	You may obtain a copy of the License at
-	
+
 	http://www.apache.org/licenses/LICENSE-2.0
-	
+
 	Unless required by applicable law or agreed to in writing, software
 	distributed under the License is distributed on an "AS IS" BASIS,
 	WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -34,7 +34,7 @@ namespace WPCordovaClassLib.Cordova
         private readonly WebBrowser webBrowser;
 
         /// <summary>
-        /// Creates new instance of a NativeExecution class. 
+        /// Creates new instance of a NativeExecution class.
         /// </summary>
         /// <param name="browser">Reference to web part where application is hosted</param>
         public NativeExecution(ref WebBrowser browser)
@@ -135,22 +135,11 @@ namespace WPCordovaClassLib.Cordova
 
                 new Thread(methodInvokation).Start();
 
-                //if ((bc is File) || (bc is Accelerometer))
-                //{
-                //    // Due to some issues with the IsolatedStorage in current version of
WP8 SDK we have to run all File Api commands synchronously.
-                //    // TODO: test this in WP8 RTM
-                //    methodInvokation.Invoke();
-                //}
-                //else
-                //{
-                //    new Thread(methodInvokation).Start();
-                //}
-
             }
             catch (Exception ex)
             {
                 // ERROR
-                Debug.WriteLine(String.Format("ERROR: Unable to execute command :: {0}:{1}:{3}
",
+                Debug.WriteLine(String.Format("ERROR: Unable to execute command :: {0}:{1}:{2}
",
                     commandCallParams.Service, commandCallParams.Action, ex.Message));
 
                 this.OnCommandResult(commandCallParams.CallbackId, new PluginResult(PluginResult.Status.ERROR));


Mime
View raw message