cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shaz...@apache.org
Subject [29/40] git commit: Relaxed 3.2.0 requirement for Keyboard plugin (compile warning, and note in the docs)
Date Mon, 04 Nov 2013 22:05:43 GMT
Relaxed 3.2.0 requirement for Keyboard plugin (compile warning, and note in the docs)


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugins/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugins/commit/7959156d
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugins/tree/7959156d
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugins/diff/7959156d

Branch: refs/heads/master
Commit: 7959156dee536f49331dde9c501c4b89cdaf4445
Parents: aaf61d4
Author: Shazron Abdullah <shazron@apache.org>
Authored: Thu Oct 10 01:27:22 2013 -0700
Committer: Shazron Abdullah <shazron@apache.org>
Committed: Thu Oct 10 01:27:22 2013 -0700

----------------------------------------------------------------------
 keyboard/README.md             | 6 ++++--
 keyboard/src/ios/CDVKeyboard.m | 2 +-
 2 files changed, 5 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugins/blob/7959156d/keyboard/README.md
----------------------------------------------------------------------
diff --git a/keyboard/README.md b/keyboard/README.md
index 61af1cd..763c8ea 100644
--- a/keyboard/README.md
+++ b/keyboard/README.md
@@ -3,9 +3,11 @@ Keyboard
 
 > The `Keyboard` object provides some functions to customize the iOS keyboard.
 
-This plugin only runs in Cordova 3.2 or greater. This plugin contains the keyboard customization
code present in the core in previous Cordova versions, and thus can't be used in those versions.

+This plugin has only been tested in Cordova 3.2 or greater, and its use in previous Cordova
versions is not recommended (potential conflict with keyboard customization code present in
the core in previous Cordova versions). 
 
-This plugin supports the old __HideKeyboardFormAccessoryBar__ and __KeyboardShrinksView__
boolean preferences in config.xml as well.
+If you do use this plugin in an older Cordova version (again, not recommended), you have
to make sure the HideKeyboardFormAccessoryBar and KeyboardShrinksView preference values are
*always* false, and only use the API functions to turn things on/off.
+
+This plugin supports the __HideKeyboardFormAccessoryBar__ (boolean) and __KeyboardShrinksView__
(boolean) preferences in config.xml.
 
 Methods
 -------

http://git-wip-us.apache.org/repos/asf/cordova-plugins/blob/7959156d/keyboard/src/ios/CDVKeyboard.m
----------------------------------------------------------------------
diff --git a/keyboard/src/ios/CDVKeyboard.m b/keyboard/src/ios/CDVKeyboard.m
index 06131e8..1cca6a9 100644
--- a/keyboard/src/ios/CDVKeyboard.m
+++ b/keyboard/src/ios/CDVKeyboard.m
@@ -21,7 +21,7 @@
 #import <Cordova/CDVAvailability.h>
 
 #ifndef __CORDOVA_3_2_0
-#error "This plugin is only supported in Cordova 3.2 or greater."
+#warning "The keyboard plugin is only supported in Cordova 3.2 or greater, it may not work
properly in an older version. If you do use this plugin in an older version, make sure the
HideKeyboardFormAccessoryBar and KeyboardShrinksView preference values are false."
 #endif
 
 @interface CDVKeyboard ()


Mime
View raw message