cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From i..@apache.org
Subject spec commit: CB-5405: Remove test that doesn't make sense for filesystem URLs
Date Mon, 18 Nov 2013 19:41:37 GMT
Updated Branches:
  refs/heads/master 196bb1f07 -> e82cff74b


CB-5405: Remove test that doesn't make sense for filesystem URLs


Project: http://git-wip-us.apache.org/repos/asf/cordova-mobile-spec/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-mobile-spec/commit/e82cff74
Tree: http://git-wip-us.apache.org/repos/asf/cordova-mobile-spec/tree/e82cff74
Diff: http://git-wip-us.apache.org/repos/asf/cordova-mobile-spec/diff/e82cff74

Branch: refs/heads/master
Commit: e82cff74b52bd44525817a39b8f508b26bc892a8
Parents: 196bb1f
Author: Ian Clelland <iclelland@chromium.org>
Authored: Mon Nov 18 13:54:23 2013 -0500
Committer: Ian Clelland <iclelland@chromium.org>
Committed: Mon Nov 18 13:54:23 2013 -0500

----------------------------------------------------------------------
 autotest/tests/file.tests.js | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-mobile-spec/blob/e82cff74/autotest/tests/file.tests.js
----------------------------------------------------------------------
diff --git a/autotest/tests/file.tests.js b/autotest/tests/file.tests.js
index e830dc4..9ed6776 100644
--- a/autotest/tests/file.tests.js
+++ b/autotest/tests/file.tests.js
@@ -649,7 +649,15 @@ describe('File API', function() {
 
             waitsFor(function() { return getDir.wasCalled; }, "getDir never called", Tests.TEST_TIMEOUT);
         });
-        it("file.spec.25 DirectoryEntry.getDirectory: create new dir with space resolveFileSystemURI
with encoded URI", function() {
+
+        // This test is excluded, and should probably be removed. Filesystem
+        // should always be properly encoded URLs, and *not* raw paths, and it
+        // doesn't make sense to double-encode the URLs and expect that to be
+        // handled by the implementation.
+        // If a particular platform uses paths internally rather than URLs,
+        // then that platform should careful to pass them correctly to its
+        // backend.
+        xit("file.spec.25 DirectoryEntry.getDirectory: create new dir with space resolveFileSystemURI
with encoded URI", function() {
             var dirName = "de create dir",
                 dirPath = joinURL(root.fullPath, dirName),
                 getDir = jasmine.createSpy().andCallFake(function(dirEntry) {


Mime
View raw message