cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabb...@apache.org
Subject [08/16] git commit: Rewrite properties set, to better match project code style
Date Tue, 26 Nov 2013 02:02:20 GMT
Rewrite properties set, to better match project code style


Project: http://git-wip-us.apache.org/repos/asf/cordova-cli/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-cli/commit/f810232f
Tree: http://git-wip-us.apache.org/repos/asf/cordova-cli/tree/f810232f
Diff: http://git-wip-us.apache.org/repos/asf/cordova-cli/diff/f810232f

Branch: refs/heads/master
Commit: f810232f9b995b2aeb0c7d06f5170c37ec12d3c8
Parents: 4f19c86
Author: SomaticIT <contact@somatic.fr>
Authored: Mon Nov 18 18:25:52 2013 +0100
Committer: SomaticIT <contact@somatic.fr>
Committed: Mon Nov 18 18:25:52 2013 +0100

----------------------------------------------------------------------
 src/metadata/windows8_parser.js | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-cli/blob/f810232f/src/metadata/windows8_parser.js
----------------------------------------------------------------------
diff --git a/src/metadata/windows8_parser.js b/src/metadata/windows8_parser.js
index 62b129c..9e03486 100644
--- a/src/metadata/windows8_parser.js
+++ b/src/metadata/windows8_parser.js
@@ -131,19 +131,13 @@ module.exports.prototype = {
         var properties = manifest.find('.//Properties');
         if (properties) {
             var displayNameElement = properties.find('.//DisplayName');
-            if (displayNameElement) {
-                var displayName = displayNameElement.text;
-                if (displayName != name) {
-                    displayNameElement.text = name;
-                }
+            if (displayNameElement && displayNameElement.text != name) {
+                displayNameElement.text = name;
             }
 
             var publisherNameElement = properties.find('.//PublisherDisplayName');
-            if (publisherNameElement) {
-                var publisherName = publisherNameElement.text;
-                if (publisherName != author) {
-                    publisherNameElement.text = author;
-                }
+            if (publisherNameElement && publisherNameElement.text != author) {
+                publisherNameElement.text = author;
             }
         }
 


Mime
View raw message