cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ste...@apache.org
Subject [23/51] [abbrv] git commit: Update wp8_parser.js
Date Wed, 27 Nov 2013 22:27:22 GMT
Update wp8_parser.js

Fails to add windows package, files with 0 sizes are not directories.
        [phonegap] adding the Windows Phone 8 platform...
        Fatal error:
        npm\node_modules\phonegap\node_modules\cordova\src\metadata\wp8_parser.
        js:220
                    if(stat.size == 0 {
                                      ^
        SyntaxError: Unexpected token {
            at Module._compile (module.js:439:25)
            at Object.Module._extensions..js (module.js:474:10)
            at Module.load (module.js:356:32)
            at Function.Module._load (module.js:312:12)
            at Module.require (module.js:364:17)
            at Object.defineProperty.get [as parser] (c:\Users\AppData\Roaming\npm\node_modules\phonegap
        \node_modules\cordova\src\util.js:140:55)
            at Function.module.exports.supports (c:\Users\AppData\Roaming\npm\node_modules\phonegap\node
        _modules\cordova\src\platform.js:259:41)
            at call_into_create (c:\Users\AppData\Roaming\npm\node_modules\phonegap\node_modules\cordova
        \src\platform.js:295:24)
            at c:\Users\AppData\Roaming\npm\node_modules\phonegap\node_modules\cordova\src\platform.js:9
        6:29
            at c:\Users\AppData\Roaming\npm\node_modules\phonegap\node_modules\cordova\src\lazy_load.js:
        48:31

Project: http://git-wip-us.apache.org/repos/asf/cordova-cli/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-cli/commit/84aeb98f
Tree: http://git-wip-us.apache.org/repos/asf/cordova-cli/tree/84aeb98f
Diff: http://git-wip-us.apache.org/repos/asf/cordova-cli/diff/84aeb98f

Branch: refs/heads/fireos
Commit: 84aeb98fb9952288c7565d59719a399ab7ef5230
Parents: c2d031b
Author: junaidrsd <junaid@sc5.fi>
Authored: Wed Nov 20 16:45:00 2013 +0200
Committer: junaidrsd <junaid@sc5.fi>
Committed: Wed Nov 20 16:45:00 2013 +0200

----------------------------------------------------------------------
 src/metadata/wp8_parser.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-cli/blob/84aeb98f/src/metadata/wp8_parser.js
----------------------------------------------------------------------
diff --git a/src/metadata/wp8_parser.js b/src/metadata/wp8_parser.js
index 401e3c7..a16127a 100644
--- a/src/metadata/wp8_parser.js
+++ b/src/metadata/wp8_parser.js
@@ -228,7 +228,7 @@ module.exports.prototype = {
         for(item in folder_dir) {
             var stat = fs.statSync(path.join(dir, folder_dir[item]));
             // means its a folder?
-            if(stat.size == 0) {
+            if(stat.isDirectory()) {
                 var sub_dir = this.folder_contents(path.join(name, folder_dir[item]), path.join(dir,
folder_dir[item]));
                 //Add all subfolder item paths
                 for(sub_item in sub_dir) {


Mime
View raw message