cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apache Wiki <wikidi...@apache.org>
Subject [Cordova Wiki] Update of "IssueWorkflow" by JoshSoref
Date Thu, 07 Nov 2013 12:30:57 GMT
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Cordova Wiki" for change notification.

The "IssueWorkflow" page has been changed by JoshSoref:
https://wiki.apache.org/cordova/IssueWorkflow?action=diff&rev1=5&rev2=6

Comment:
first steps on running tests

  Long commit messages are not necessary, especially if there is a reference to a Jira item.
More good advice on this topic is in the [[http://git-scm.com/book/ch5-2.html#Commit-Guidelines|Git
book]].
  
  === Test Your Changes ===
- The contributor is responsible to test their changes and correct any problems with their
changes before a pull request is submitted. The testing includes both verifying the function
they added/touched, plus running the test suites to verify there are no regressions.
+ The contributor is responsible for testing their changes and correcting any problems with
their changes before submitting a pull request. Testing includes both verifying the functionality
added/touched, and plus [[RunningTests|running the test suites]] to verify there are no regressions.
  
- When we say "run the test suites" this includes all automated tests in mobile-spec, manual
tests in mobile-spec that might be affected by the change, and any platform-specific unit
tests (i.e., cordova-android/test, cordova-ios/CordovaLibTests, cordova-js jake test, cordova-plugman
npm test, etc.)
+ When we say "run the test suites" this includes:
+  * all automated tests in mobile-spec,
+  * manual tests in mobile-spec that might be affected by the change,
+  * any platform-specific unit tests
+   * cordova-android/test,
+   * cordova-ios/CordovaLibTests,
+   * cordova-js jake test,
+   * cordova-plugman npm test,
  
- It is recommended that you add a comment in Jira about what testing you did with your change,
so a committer can understand what testing was done before they merge your change. It is also
recommended that where reasonably feasible, you add automated tests to validate your change
and catch any future regressions.
+ Please add a comment in Jira about what testing you did with your change, so a committer
can understand what testing was done before they merge your change. Please where reasonably
feasible add automated tests to validate your change and catch any future regressions.
  
+ === Documentation ===
  If you are writing documentation (i.e., cordova-docs), then be aware of the [[https://github.com/apache/cordova-docs/blob/master/STYLESHEET.md|style
guidelines]].
  
  === Commit More File Changes ===

Mime
View raw message