cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shaz...@apache.org
Subject [30/40] git commit: Made hideFormAccessoryBar a readwrite property again - it turns out the keyboard view is never re-used, and always created on use.
Date Mon, 04 Nov 2013 22:05:44 GMT
Made hideFormAccessoryBar a readwrite property again - it turns out the keyboard view is never
re-used, and always created on use.


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugins/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugins/commit/33cf7118
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugins/tree/33cf7118
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugins/diff/33cf7118

Branch: refs/heads/master
Commit: 33cf7118e3a9faafcbdfbb642bed30c046bbf430
Parents: 7959156
Author: Shazron Abdullah <shazron@apache.org>
Authored: Thu Oct 10 18:25:34 2013 -0700
Committer: Shazron Abdullah <shazron@apache.org>
Committed: Thu Oct 10 18:25:34 2013 -0700

----------------------------------------------------------------------
 keyboard/src/ios/CDVKeyboard.h | 2 +-
 keyboard/src/ios/CDVKeyboard.m | 4 ----
 2 files changed, 1 insertion(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugins/blob/33cf7118/keyboard/src/ios/CDVKeyboard.h
----------------------------------------------------------------------
diff --git a/keyboard/src/ios/CDVKeyboard.h b/keyboard/src/ios/CDVKeyboard.h
index f59294c..dca1fb5 100644
--- a/keyboard/src/ios/CDVKeyboard.h
+++ b/keyboard/src/ios/CDVKeyboard.h
@@ -36,7 +36,7 @@
 
 @property (readwrite, assign) BOOL shrinkView;
 @property (readwrite, assign) BOOL disableScrollingInShrinkView;
-@property (readonly, assign)  BOOL hideFormAccessoryBar;
+@property (readwrite, assign)  BOOL hideFormAccessoryBar;
 @property (readonly, assign)  BOOL keyboardIsVisible;
 
 

http://git-wip-us.apache.org/repos/asf/cordova-plugins/blob/33cf7118/keyboard/src/ios/CDVKeyboard.m
----------------------------------------------------------------------
diff --git a/keyboard/src/ios/CDVKeyboard.m b/keyboard/src/ios/CDVKeyboard.m
index 1cca6a9..ada6082 100644
--- a/keyboard/src/ios/CDVKeyboard.m
+++ b/keyboard/src/ios/CDVKeyboard.m
@@ -27,7 +27,6 @@
 @interface CDVKeyboard ()
 
 @property (nonatomic, readwrite, assign) BOOL keyboardIsVisible;
-@property (nonatomic, readwrite, assign) BOOL hideFormAccessoryBar;
 
 @end
 
@@ -228,9 +227,6 @@
 
 - (void)formAccessoryBarKeyboardWillHide:(NSNotification*)notif
 {
-    // TODO: incomplete - we can't restore the accessory bar currently, this is why the public
interface for the setting is readonly.
-    // Not entirely sure we can restore this properly in the same hierarchy, even if we save
the references
-
     // restore the scrollview frame
     self.webView.scrollView.frame = self.webView.frame;
 }


Mime
View raw message