cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agri...@apache.org
Subject [1/2] git commit: Fix broken JS in file-extras (still somewhat a WIP).
Date Fri, 11 Oct 2013 03:01:41 GMT
Updated Branches:
  refs/heads/plugins 2b9e4c238 -> d120e9d3a


Fix broken JS in file-extras (still somewhat a WIP).


Project: http://git-wip-us.apache.org/repos/asf/cordova-labs/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-labs/commit/d120e9d3
Tree: http://git-wip-us.apache.org/repos/asf/cordova-labs/tree/d120e9d3
Diff: http://git-wip-us.apache.org/repos/asf/cordova-labs/diff/d120e9d3

Branch: refs/heads/plugins
Commit: d120e9d3af20aaa27b7893150043d6864ccfbf03
Parents: fb8286f
Author: Andrew Grieve <agrieve@chromium.org>
Authored: Thu Oct 10 22:59:17 2013 -0400
Committer: Andrew Grieve <agrieve@chromium.org>
Committed: Thu Oct 10 23:01:06 2013 -0400

----------------------------------------------------------------------
 file-extras/fileextras.js | 4 ++--
 file-extras/plugin.xml    | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-labs/blob/d120e9d3/file-extras/fileextras.js
----------------------------------------------------------------------
diff --git a/file-extras/fileextras.js b/file-extras/fileextras.js
index 1f8f88f..a5eb426 100644
--- a/file-extras/fileextras.js
+++ b/file-extras/fileextras.js
@@ -31,7 +31,7 @@ var DirectoryEntry = require('org.apache.cordova.file.DirectoryEntry');
 //   * e.g. On Android, could use same schemes for 3.0+, or use content://cordova-app/app-data://...
for 2.3
 //   * This would mean APIs could be synchronous, and platform-specific locations can be
kept on native side.
 //   * This would allow things to be used as URLs for images.
-//   * APIs (such as FileTransfer) work better with URLs
+//   * APIs (such as FileTransfer) work better with URLs (Paths are annoying, esp with Windows
using \)
 //   * Entry have a toURL() already. Without custom schemes, it won't work for Android resources
& assets
 // * Add support resolveLocalFileSystemURL()?
 
@@ -58,7 +58,7 @@ fileextras.getDirectoryForPurpose = function(purpose, options, successCallback,
         successCallback(directoryEntry);
     };
 
-    var purposeInt = Persistence[purpose];
+    var purposeInt = Purpose[purpose];
     if (typeof purposeInt == 'undefined') {
         throw new Error('getDirectoryForPurpose: invalid purpose: ' + purpose);
     }

http://git-wip-us.apache.org/repos/asf/cordova-labs/blob/d120e9d3/file-extras/plugin.xml
----------------------------------------------------------------------
diff --git a/file-extras/plugin.xml b/file-extras/plugin.xml
index 4df84a4..2a140e2 100644
--- a/file-extras/plugin.xml
+++ b/file-extras/plugin.xml
@@ -28,7 +28,7 @@
   <dependency id="org.apache.cordova.file" />
 
   <js-module src="fileextras.js" name="FileExtras">
-    <clobbers target="cordova.plugins.fileExtras" />
+    <clobbers target="cordova.plugins.fileextras" />
   </js-module>
 
   <platform name="android">


Mime
View raw message