cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apache Wiki <>
Subject [Cordova Wiki] Update of "CommitterWorkflow" by MarcelKinard
Date Wed, 02 Oct 2013 15:29:51 GMT
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Cordova Wiki" for change notification.

The "CommitterWorkflow" page has been changed by MarcelKinard:

add instructions on manual use of Review Board

  git clone
+ cd cordova-coho
+ npm install
+ cd ..
  cordova-coho/coho repo-clone -r plugins -r mobile-spec -r ...
@@ -64, +67 @@

  === Step 6: Ask for a code review (''optional'') ===
   * Do this if you want a second pair of eyes to look at your code before it goes in.
   * Use [[|]] to create a review request.
-    * Easiest way is to use [[|post-review]]
from the repo with the change.
+    * You will need a Review Board userid and password. One can be requested from the site.
     * By default, the ML will be notified of your review request.
     * If you have someone in particular that you would like approval from, be sure to add
them in "People" field of the review.
+    * Easiest way to create your review request is to use [[|post-review]]
(RBTools) from the repo with the change.
+    * If you don't want to use post-review, then on the web site:
+      * Click "New Review Request"
+      * On your workstation do a git diff and pipe the output to a file. In the new request,
select the git repo, the base dir where you did the diff, upload the diff file you created,
and click Create.
+      * On the next web page, fill in the description text, the name of the Branch (i.e.,
"master"), the Bug (i.e., "CB-4960"), the Description and the Testing Done fields. If you
want a review from a specific person, enter their userid / name in the People field. If you
want input from the whole community, enter "cordova" in the Groups field. Click the Submit
+      * After you have received sufficient feedback, click the button to mark your review
as Discarded or Submitted [to a stream].
  === Step 7: Push your change ===
   * Rebase & commit it to the appropriate branch (see "''Which Branch to Commit To''"

View raw message