cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agri...@apache.org
Subject git commit: [CB-4771] Expose TEMPORARY and PERSISTENT constants on window.
Date Tue, 10 Sep 2013 17:44:22 GMT
Updated Branches:
  refs/heads/dev 4d24eeee1 -> d20b0ac58


[CB-4771] Expose TEMPORARY and PERSISTENT constants on window.


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-file/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-file/commit/d20b0ac5
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-file/tree/d20b0ac5
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-file/diff/d20b0ac5

Branch: refs/heads/dev
Commit: d20b0ac58bc9354686c3f6c883fa063d13071cf0
Parents: 4d24eee
Author: Andrew Grieve <agrieve@chromium.org>
Authored: Tue Sep 10 13:43:52 2013 -0400
Committer: Andrew Grieve <agrieve@chromium.org>
Committed: Tue Sep 10 13:43:52 2013 -0400

----------------------------------------------------------------------
 plugin.xml             |  3 +++
 www/LocalFileSystem.js | 15 ++-------------
 2 files changed, 5 insertions(+), 13 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-file/blob/d20b0ac5/plugin.xml
----------------------------------------------------------------------
diff --git a/plugin.xml b/plugin.xml
index f2ab922..458798e 100644
--- a/plugin.xml
+++ b/plugin.xml
@@ -58,7 +58,10 @@ xmlns:android="http://schemas.android.com/apk/res/android"
     </js-module>
 
     <js-module src="www/LocalFileSystem.js" name="LocalFileSystem">
+        <!-- Non-standards way -->
         <clobbers target="window.LocalFileSystem" />
+        <!-- Standards-compliant way -->
+        <merges target="window" />
     </js-module>
 
     <js-module src="www/Metadata.js" name="Metadata">

http://git-wip-us.apache.org/repos/asf/cordova-plugin-file/blob/d20b0ac5/www/LocalFileSystem.js
----------------------------------------------------------------------
diff --git a/www/LocalFileSystem.js b/www/LocalFileSystem.js
index dae7683..1e8f2ee 100644
--- a/www/LocalFileSystem.js
+++ b/www/LocalFileSystem.js
@@ -19,16 +19,5 @@
  *
 */
 
-var exec = require('cordova/exec');
-
-/**
- * Represents a local file system.
- */
-var LocalFileSystem = function() {
-
-};
-
-LocalFileSystem.TEMPORARY = 0; //temporary, with no guarantee of persistence
-LocalFileSystem.PERSISTENT = 1; //persistent
-
-module.exports = LocalFileSystem;
+exports.TEMPORARY = 0;
+exports.PERSISTENT = 1;


Mime
View raw message