cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jeffheif...@apache.org
Subject [37/50] [abbrv] webworks commit: [CB-4762] Added a fix to the run script to error out when the IP is not found
Date Fri, 27 Sep 2013 14:26:41 GMT
[CB-4762] Added a fix to the run script to error out when the IP is not found

Reviewed by Bryan Higgins <bhiggins@blackberry.com>
Tested by Daniel Audino <daudino@blackberry.com>


Project: http://git-wip-us.apache.org/repos/asf/cordova-blackberry/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-blackberry/commit/fbe4de9c
Tree: http://git-wip-us.apache.org/repos/asf/cordova-blackberry/tree/fbe4de9c
Diff: http://git-wip-us.apache.org/repos/asf/cordova-blackberry/diff/fbe4de9c

Branch: refs/heads/3.1.x
Commit: fbe4de9c1f4f91fe95106177696bc73decbc8ade
Parents: 5334f10
Author: Jeffrey Heifetz <jheifetz@blackberry.com>
Authored: Mon Sep 9 11:16:37 2013 -0400
Committer: Bryan Higgins <bhiggins@blackberry.com>
Committed: Mon Sep 16 15:28:59 2013 -0400

----------------------------------------------------------------------
 blackberry10/bin/templates/project/cordova/lib/run | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-blackberry/blob/fbe4de9c/blackberry10/bin/templates/project/cordova/lib/run
----------------------------------------------------------------------
diff --git a/blackberry10/bin/templates/project/cordova/lib/run b/blackberry10/bin/templates/project/cordova/lib/run
index 3aa386d..e07965c 100755
--- a/blackberry10/bin/templates/project/cordova/lib/run
+++ b/blackberry10/bin/templates/project/cordova/lib/run
@@ -109,7 +109,7 @@ function getTargetName (done) {
             {
                 ip: function (done) {
                     ipFinder(function (ip) {
-                        done(null, ip);
+                        done(ip ? null : "No connected BlackBerry 10 " + targetType + " found",
ip);
                     });
                 },
                 devicePass: function (done) {
@@ -127,8 +127,6 @@ function getTargetName (done) {
             function (err, results) {
                 if (err) {
                     done(err);
-                } else if (!results.ip) {
-                    done("No connected BlackBerry 10 " + targetType + " found");
                 } else {
                     program.devicepass = results.devicePass;
                     checkDeviceInfo(results.ip, targetType, results.devicePass, done);


Mime
View raw message