cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tim...@apache.org
Subject [08/17] git commit: [CB-4036] - fixed up some small errors
Date Mon, 26 Aug 2013 23:47:42 GMT
[CB-4036] - fixed up some small errors


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugman/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugman/commit/faccfd55
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugman/tree/faccfd55
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugman/diff/faccfd55

Branch: refs/heads/master
Commit: faccfd55009b98306fb1ff63678817088849a8b3
Parents: 078f9bf
Author: Tim Kim <timk@adobe.com>
Authored: Thu Aug 8 13:50:18 2013 -0700
Committer: Tim Kim <timk@adobe.com>
Committed: Mon Aug 26 16:47:16 2013 -0700

----------------------------------------------------------------------
 src/install.js | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugman/blob/faccfd55/src/install.js
----------------------------------------------------------------------
diff --git a/src/install.js b/src/install.js
index fee217e..accc25a 100644
--- a/src/install.js
+++ b/src/install.js
@@ -83,9 +83,9 @@ function callEngineScripts(engines) {
     var engineScriptVersion;
     
     engines.forEach(function(engine){
-        if(fs.exists(engine.scriptTarget)){
+        if(fs.existsSync(engine.scriptTarget)){
             fs.chmodSync(engine.scriptTarget, '755');
-            engineScript = shell.exec(versionPath, {silent: true});
+            engineScript = shell.exec(engine.scriptTarget, {silent: true});
             
             if (engineScript.code === 0) {
                 engineScriptVersion = engineScript.output.trim();
@@ -103,7 +103,6 @@ function callEngineScripts(engines) {
             require('../plugman').emit('log', 'Cordova project '+ engine.scriptTarget +'
not detected (lacks a '+ engine.scriptTarget +' script), continuing.');
         } 
         engine.currentVersion = engineScriptVersion;
-        
     });
     
     return engines;
@@ -121,7 +120,7 @@ function getEngines(pluginElement, platform, project_dir){
         // this may need some changes - what to do for default platforms - why need to specify
platforms?
         if(engine.attrib["platform"] === platform || engine.attrib["platform"] === '*'){
             if(defaultEngines[engine.attrib["name"]]){
-                defaultEngines[engine.attrib["name"]].minVersion = defaultEngines[engine.attrib["version"]];
+                defaultEngines[engine.attrib["name"]].minVersion = engine.attrib["version"];
                 defaultEngines[engine.attrib["name"]].scriptTarget = path.join(project_dir,
defaultEngines[engine.attrib["name"]].scriptTarget);
                 uncheckedEngines.push(defaultEngines[engine.attrib["name"]]);
             }else{


Mime
View raw message